Converted Assume Role to C# and also Fixed Secret Key Access to Non-Plain Text #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zephyrz73
commented
Jul 8, 2020
zephyrz73
commented
- Conversion assume-role to cs
- Encryped secret access key
- Indicate encryption in read me
- Add tests for aws-cs-assume-role and delete test for aws serverless-raw
added 11 commits
July 2, 2020 10:13
…te encryption in read me 3. add tests for aws-cs-assume-role and delete test for aws serverless-raw
zephyrz73
changed the title
zephyrz73
changed the title
…ame to be cs-create-role
justinvp
reviewed
Jul 13, 2020
There was a problem hiding this comment.
There is a 67.6 MB binary aws-go-assume-role/assume-role/assume-role that should be deleted.
Some minor other things, but looks good otherwise!
Note: There are links in the root README.md to the AssumeRole example for TypeScript and Python. Want to add links for Go and C#? For example: https://github.com/pulumi/examples/blame/master/README.md#L60
added 3 commits
July 14, 2020 10:29
…n cs, and unnecessary plugins
justinvp
approved these changes
Jul 15, 2020
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
Converted Assume Role to C# and also Fixed Secret Key Access to Non-Plain Text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.