Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted aws assume-role to go, add README.md, and the test for it #738

Closed
wants to merge 11 commits into from

Conversation

zephyrz73
Copy link
Contributor

  1. Fixing the line break in README.md of aws-py-serverless-raw
  2. Converted aws-ts-assume-role to aws-go-assume-role
  3. Add test to misc/test/examples_test.go

@zephyrz73
Copy link
Contributor Author

Seems like the dotnet publish command functionality is still under development. The test for aws-ts/py-serverless-raw is skipped in that case. The assume-role test works fine.

@zephyrz73 zephyrz73 requested a review from justinvp July 7, 2020 16:20
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

aws-go-assume-role/assume-role/main.go Outdated Show resolved Hide resolved
misc/test/examples_test.go Show resolved Hide resolved
misc/test/examples_test.go Show resolved Hide resolved
@zephyrz73 zephyrz73 closed this Jul 9, 2020
@zephyrz73 zephyrz73 reopened this Jul 9, 2020
@justinvp
Copy link
Member

@zephyrz73, is #744 meant to replace this PR? If so, should this be closed?

@zephyrz73 zephyrz73 closed this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants