Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set pipefail option when running tests #1600

Merged
merged 1 commit into from
Feb 22, 2024
Merged

set pipefail option when running tests #1600

merged 1 commit into from
Feb 22, 2024

Commits on Feb 22, 2024

  1. set pipefail option when running tests

    When running the tests in CI, we're piping the output of `go test`
    into gotestfmt to get prettier output.  This works because `gotestfmt`
    will return a non-zero exit code when there are test failures.
    
    However when there are other failures, e.g. compilation of the tests
    failed, `gotestfmt` will have a 0 exit code.  `go test` wouldn't, but
    because we're piping the results through, the shell swallows that
    unless we're setting the pipefail option.
    
    Set up the pipefail option here, so tests aren't accidentally green
    when compilation fails.
    tgummerer committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5f61b35 View commit details
    Browse the repository at this point in the history