set pipefail option when running tests #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the tests in CI, we're piping the output of `go test` into gotestfmt to get prettier output. This works because `gotestfmt` will return a non-zero exit code when there are test failures. However when there are other failures, e.g. compilation of the tests failed, `gotestfmt` will have a 0 exit code. `go test` wouldn't, but because we're piping the results through, the shell swallows that unless we're setting the pipefail option. Set up the pipefail option here, so tests aren't accidentally green when compilation fails.
tgummerer
force-pushed
the
tg/pipefail
branch
from
ddaef08
to
5f61b35
Compare
thomas11
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tests in CI, we're piping the output of
go testinto gotestfmt to get prettier output. This works becausegotestfmtwill return a non-zero exit code when there are test failures.However when there are other failures, e.g. compilation of the tests failed,
gotestfmtwill have a 0 exit code.go testwouldn't, but because we're piping the results through, the shell swallows that unless we're setting the pipefail option.Set up the pipefail option here, so tests aren't accidentally green when compilation fails.
/cc @thomas11 who noticed the tests were passing even though compilation failed in #1595