Convert Go Azure examples to fnOutput form #1154
azure-go-appservice-docker updated azure-native dependency. changed i…
…mage to pull since the old image 404s. refactored to use fnOutput form
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ func main() { | |
| // The example uses a HelloWorld application written in Go. | ||
| // Image: https://hub.docker.com/r/microsoft/azure-appservices-go-quickstart/ | ||
| // | ||
|
There was a problem hiding this comment. this image was 404'ing I replaced it with an nginx base image since it's about deploying an image from docker hub |
||
| imageInDockerHub := "mcr.microsoft.com/azuredocs/aci-helloworld" | ||
| helloApp, err := web.NewWebApp(ctx, "helloApp", &web.WebAppArgs{ | ||
| ResourceGroupName: resourceGroup.Name, | ||
| ServerFarmId: plan.ID(), | ||
|
|
@@ -57,7 +57,7 @@ func main() { | |
| } | ||
|
|
||
| ctx.Export("helloEndpoint", helloApp.DefaultHostName.ApplyT(func(defaultHostName string) (string, error) { | ||
|
There was a problem hiding this comment. the nginx image doesn't have a |
||
| return fmt.Sprintf("%v%v", "https://", defaultHostName), nil | ||
| }).(pulumi.StringOutput)) | ||
|
|
||
| // | ||
|
|
@@ -75,25 +75,13 @@ func main() { | |
| return err | ||
| } | ||
|
|
||
| credentials := containerregistry.ListRegistryCredentialsOutput(ctx, containerregistry.ListRegistryCredentialsOutputArgs{ | ||
|
|
||
| RegistryName: registry.Name, | ||
| ResourceGroupName: resourceGroup.Name, | ||
| }) | ||
|
|
||
| adminUsername := credentials.Username().Elem() | ||
| adminPassword := credentials.Passwords().Index(pulumi.Int(0)).Value().Elem() | ||
|
|
||
| myImage, err := docker.NewImage(ctx, customImage, &docker.ImageArgs{ | ||
| ImageName: registry.LoginServer.ApplyT(func(result string) (string, error) { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the image to an image that exists so I updated the README with the expected outputs.