Convert Go Azure examples to fnOutput form #1154

dixler · 2022-01-21T15:48:37Z

examples/azure-go-containerapps
attempted bumping azure-native, but ran into an issue another user ran into. It was due to an upstream dependency on azure. Omitting changes.

…config function

…ure compatible one. removed KubeDashboard since incompatible with azure compatible kubernetes

…version

…mage to pull since the old image 404s. refactored to use fnOutput form

dixler · 2022-01-21T15:53:51Z

azure-go-aks-helm/config.go

@@ -30,7 +30,7 @@ func configure(ctx *pulumi.Context) (Config, error) {

 out.K8sVersion = cfg.Get("k8sVersion")
 if out.K8sVersion == "" {
- out.K8sVersion = "1.18.14"


This k8s version was no longer supported.

Sounds good.

dixler · 2022-01-21T15:54:53Z

azure-go-aks-helm/cluster.go

@@ -54,11 +54,6 @@ func buildCluster(ctx *pulumi.Context, cfg Config) (*ClusterInfo, error) {
 k8sCluster, err := cs.NewManagedCluster(ctx, "cluster",
 &cs.ManagedClusterArgs{
 ResourceGroupName: resourceGroup.Name,
- AddonProfiles: cs.ManagedClusterAddonProfileMap{


The k8s version bump broke compatibility with this addon so I removed it. It didn't appear to be a significant part of the README.

Sounds good.

dixler · 2022-01-21T15:57:28Z

azure-go-aks/main.go

@@ -13,6 +13,27 @@ import (
 "github.com/pulumi/pulumi/sdk/v3/go/pulumi"
 )

+func getKubeconfig(ctx *pulumi.Context, cluster *containerservice.ManagedCluster, resourceGroup *resources.ResourceGroup) pulumi.Output {


Broke this out into a separate function to break apart the instantiation logic and the kubeconfig logic.

dixler · 2022-01-21T15:58:19Z

azure-go-appservice-docker/README.md

@@ -48,9 +48,33 @@ The example shows two scenarios:

 ```
 $ pulumi stack output helloEndpoint
- http:https://hello-app-91dfea.azurewebsites.net/hello


I changed the image to an image that exists so I updated the README with the expected outputs.

dixler · 2022-01-21T16:05:08Z

azure-go-appservice-docker/main.go

 //
- imageInDockerHub := "microsoft/azure-appservices-go-quickstart"


this image was 404'ing

I replaced it with an nginx base image since it's about deploying an image from docker hub

dixler · 2022-01-21T16:05:35Z

azure-go-appservice-docker/main.go

@@ -57,7 +57,7 @@ func main() {
 }

 ctx.Export("helloEndpoint", helloApp.DefaultHostName.ApplyT(func(defaultHostName string) (string, error) {
- return fmt.Sprintf("%v%v%v", "https://", defaultHostName, "/hello"), nil


the nginx image doesn't have a /hello route

dixler · 2022-01-21T16:06:53Z

azure-go-call-azure-sdk/main.go

@@ -44,7 +44,7 @@ func main() {
 }
 _, err = authorization.NewRoleAssignment(ctx, "access-from-cluster", &authorization.RoleAssignmentArgs{
 PrincipalId: pulumi.String(currentPrincipal),
- PrincipalType: authorization.PrincipalTypeUser, // adjust the type if you are running as a service principal


Bumped the version and this line threw an error.

dixler · 2022-01-21T16:07:40Z

azure-go-static-website/main.go

@@ -22,7 +22,7 @@ func main() {
 profile, err := cdn.NewProfile(ctx, "profile", &cdn.ProfileArgs{
 ResourceGroupName: resourceGroup.Name,
 Sku: &cdn.SkuArgs{
- Name: cdn.SkuName_Standard_Microsoft,


Bumped the version and this line threw an error.

t0yv0 · 2022-01-21T16:13:24Z

azure-go-aci/main.go

- }
- return *ip.Ip, nil
- }).(pulumi.StringOutput))
+ ctx.Export("containerIPv4Address", containerGroup.IpAddress.Ip())


The ApplyT used to coerce *string to string by interpreting nil as "". IS that still happening? Does ctx.Export work with nils? Have you had a chance to test this? The CI does not test all examples.

kdixler@kdixler-20xw004aus ~/GolandProjects/examples/azure-go-aci (git)-[dixler/1115/refactor-azure-go-binless] % pulumi up Previewing update (issue1115) View Live: https://app.pulumi.com/kyle/azure-go-aci/issue1115/previews/c49fb6bf-3e9c-4581-b200-56878bd789e1 Type Name Plan + pulumi:pulumi:Stack azure-go-aci-issue1115 create + ├─ azure-native:resources:ResourceGroup aci-rg create + └─ azure-native:containerinstance:ContainerGroup helloworld create Resources: + 3 to create Do you want to perform this update? yes Updating (issue1115) View Live: https://app.pulumi.com/kyle/azure-go-aci/issue1115/updates/6 Type Name Status + pulumi:pulumi:Stack azure-go-aci-issue1115 created + ├─ azure-native:resources:ResourceGroup aci-rg created + └─ azure-native:containerinstance:ContainerGroup helloworld created Outputs: containerIPv4Address: "20.120.145.148" Resources: + 3 created Duration: 1m11s

t0yv0 · 2022-01-21T16:15:42Z

azure-go-aks/main.go

+ kubeconfig := pulumi.All(cluster.Name, resourceGroup.Name, resourceGroup.ID()).ApplyT(func(args interface{}) (string, error) {
+ clusterName := args.([]interface{})[0].(string)
+ resourceGroupName := args.([]interface{})[1].(string)
+ creds, err := containerservice.ListManagedClusterUserCredentials(ctx, &containerservice.ListManagedClusterUserCredentialsArgs{


Is there now a ListManagedClusterUserCredentialsOutput function?

The idea is that the code may be simplified if you use that since it would let you avoid pulumi.All plus unpacking of args. You would pass cluster.Name etc directly to that function.

t0yv0 · 2022-01-21T16:16:24Z

azure-go-appservice-docker/main.go

- })
- },
- )
+ credentials := containerregistry.ListRegistryCredentialsOutput(ctx, containerregistry.ListRegistryCredentialsOutputArgs{


t0yv0

Looking good, had a few comments. Are these all examples that can use Output forms? I vaguely remember a few more but I don't have a list handy. Let me check my notes.

t0yv0 · 2022-01-21T16:24:05Z

Mini list in #1094 - if you haven't looked at those yet it'd be good to double-check

The following examples cannot update yet because pulumi-azure-native Go SDK opts out of the feature via a flag:

azure-go-aks
azure-go-aks-helm
azure-go-appservice-docker
They do look like they would benefit.

dixler · 2022-01-21T18:15:09Z

azure-go-aks-helm/cluster.go

@@ -98,25 +93,21 @@ func buildCluster(ctx *pulumi.Context, cfg Config) (*ClusterInfo, error) {
 }

 func getKubeconfig(ctx *pulumi.Context, cluster *ClusterInfo) pulumi.StringOutput {


Found and refactored this function as well @t0yv0

t0yv0 · 2022-01-21T19:37:53Z

azure-go-aks/main.go

+
+ kubeconfig := creds.Kubeconfigs().Index(pulumi.Int(0)).Value().
+ ApplyT(func(encoded string) string {
+ kubeconfig, err := base64.StdEncoding.DecodeString(encoded)


Looking good I'm just paranoid about go runtime errors , sometimes Go compiles but throws a runtime error; running this would be invaluable (unless it's included in CI).

t0yv0 · 2022-01-21T19:40:47Z

Still LGTM.

t0yv0 · 2022-01-21T19:42:25Z

Is CI failure related to the changes? CI here is sometimes a little flaky.

dixler · 2022-01-21T19:52:47Z

Is CI failure related to the changes? CI here is sometimes a little flaky.

/home/runner/work/examples/examples/classic-azure-ts-stream-analytics
seems to be a different example than the ones I worked on.

Kyle Dixler added 8 commits January 19, 2022 12:35

updated azure-go-aci dependencies and simplified outputs

34e80a8

updated azure-go-aks dependencies, kubernetes version, broke out kube…

7e6bb9b

…config function

azure-go-aks-helm bumped package version and kubernetes version to az…

85d653a

…ure compatible one. removed KubeDashboard since incompatible with azure compatible kubernetes

azure-go-aks-multicluster bumped azure-native version and kubernetes …

58e0c75

…version

azure-go-appservice-docker updated azure-native dependency. changed i…

8c22bec

…mage to pull since the old image 404s. refactored to use fnOutput form

azure-go-appservice-docker changed image to dockerhub nginx

5de4568

azure-go-call-azure-sdk bumped aws-native version 1.53.0

a1e605a

bumped the version fixed upgrade errors

ae0cd5f

dixler commented Jan 21, 2022

View reviewed changes

updated comment on azure-go-appservice-docker/main.go

09c316e

dixler commented Jan 21, 2022

View reviewed changes

dixler requested review from mikhailshilkov and t0yv0 January 21, 2022 16:08

dixler marked this pull request as ready for review January 21, 2022 16:09

t0yv0 reviewed Jan 21, 2022

View reviewed changes

t0yv0 approved these changes Jan 21, 2022

View reviewed changes

Kyle Dixler added 2 commits January 21, 2022 09:08

improved azure-go-aks example

b740088

refactored azure-go-ask-helm

317d0b4

dixler commented Jan 21, 2022

View reviewed changes

dixler requested a review from t0yv0 January 21, 2022 19:36

t0yv0 reviewed Jan 21, 2022

View reviewed changes

dixler merged commit 04e4a18 into master Jan 21, 2022

pulumi-bot deleted the dixler/1115/refactor-azure-go-binless branch January 21, 2022 19:55

dixler mentioned this pull request Jan 21, 2022

Convert Go Azure examples to fnOutput form #1115

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert Go Azure examples to fnOutput form #1154

Convert Go Azure examples to fnOutput form #1154

dixler commented Jan 21, 2022 •

edited

Loading

dixler Jan 21, 2022 •

edited

Loading

t0yv0 Jan 21, 2022

dixler Jan 21, 2022

t0yv0 Jan 21, 2022

dixler Jan 21, 2022

dixler Jan 21, 2022

dixler Jan 21, 2022

dixler Jan 21, 2022

dixler Jan 21, 2022

dixler Jan 21, 2022

t0yv0 Jan 21, 2022

dixler Jan 21, 2022

t0yv0 Jan 21, 2022

t0yv0 Jan 21, 2022

t0yv0 left a comment

t0yv0 commented Jan 21, 2022

dixler Jan 21, 2022

t0yv0 Jan 21, 2022

t0yv0 commented Jan 21, 2022

t0yv0 commented Jan 21, 2022

dixler commented Jan 21, 2022

		//
		imageInDockerHub := "microsoft/azure-appservices-go-quickstart"

		@@ -98,25 +93,21 @@ func buildCluster(ctx pulumi.Context, cfg Config) (ClusterInfo, error) {
		}

		func getKubeconfig(ctx pulumi.Context, cluster ClusterInfo) pulumi.StringOutput {

Convert Go Azure examples to fnOutput form #1154

Convert Go Azure examples to fnOutput form #1154

Conversation

dixler commented Jan 21, 2022 • edited Loading

dixler Jan 21, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

t0yv0 left a comment

Choose a reason for hiding this comment

t0yv0 commented Jan 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

t0yv0 commented Jan 21, 2022

t0yv0 commented Jan 21, 2022

dixler commented Jan 21, 2022

dixler commented Jan 21, 2022 •

edited

Loading

dixler Jan 21, 2022 •

edited

Loading