Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update podspec to support installation from CocoaPods #51

Closed
wants to merge 1 commit into from

Conversation

naoey
Copy link

@naoey naoey commented Apr 18, 2019

I have been able to successfully install and build this package from CocoaPods in my project using this podspec. This does imply that I have to install the iOSPhotoEditor depedency myself in my main Podfile, but I feel it is a much cleaner solution to have that stated in the install steps than the current setup.

Closes #47

I have been able to successfully use this in my Podfile on CocoaPods 1.6.1 and so far it has worked more reliably than the current install method.

pod 'RNPhotoEditor', :path => '../node_modules/react-native-photo-editor/ios'
pod 'iOSPhotoEditor', :git => 'https://github.com/prscX/photo-editor'

pre_install do |installer|
installer.analysis_result.specifications.each do |s|
  if s.name.include?('iOSPhotoEditor')
    s.swift_version = '4.1' unless s.swift_version
  end
end

Update

Additionally, I also got these libraries to work without the need to have use_frameworks! in the consumer's Podfile. If this method of installation is desirable by other users of this library I can update this PR with more details.

mysport12 added a commit to homeeondemand/react-native-photo-editor that referenced this pull request Apr 30, 2019
Incorporates PRs prscX#42 (which builds upon prscX#11) and prscX#51

Added prettier config
Updated Example
Updated RNPhotoEditor, simplifying and removing extraneous code
Moved podspec to the root directory
Android build config settings were updated
Listed react-native as a peerDependency
@prscX
Copy link
Owner

prscX commented Jul 20, 2019

Thanks a lot @naoey for all the Effort you have added to this PR.

I have merged PR: 54 which also contains this PR changes. Considering that, I am closing this PR.

Thanks
</ Pranav >

@prscX prscX closed this Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install from CocoaPods
2 participants