Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: iOS: Copy instead of overwriting the orginial file - Android: Callback invoked after finishing editing #11

Closed
wants to merge 2 commits into from
Closed

Improvement: iOS: Copy instead of overwriting the orginial file - Android: Callback invoked after finishing editing #11

wants to merge 2 commits into from

Conversation

tonimoeckel
Copy link
Contributor

Instead of overwriting the original file, I made a change to copy the file in the tmp folder of the iOS device.

@tonimoeckel
Improvement: Copdy instead of overwriting the orginial file
c67c9b8 
Instead of overwriting the original file, I made a change to copy the file in the tmp folder of the iOS device.
@tonimoeckel
Copy link
Contributor Author

@prscX I'm not sure if this change is that what you expected. I needed this because my file was created in the tmp folder and the lib could not overwrite the file. So I had to create a new one. Thats why I used the callback to send the file path to the react native callback.

@prscX prscX self-assigned this Sep 27, 2018
@tonimoeckel tonimoeckel changed the title Improvement: Copdy instead of overwriting the orginial file Improvement: iOS: Copy instead of overwriting the orginial file - Android: Callback invoked after finishing editing Oct 11, 2018
@tonimoeckel
Copy link
Contributor Author

HI @prscX ! I also fixed a issue on android devices. At the moment the callback was not invoked on android devices. I added some lines to get the activity result und invoked the callback on result code "OK".

@jdestep93 jdestep93 mentioned this pull request Oct 13, 2018
Merged
@prscX
Copy link
Owner

prscX commented Oct 13, 2018

Thanks @tonimoeckel for the PR and Effort.

w.r.t I needed this because my file was created in the tmp folder and the lib could not overwrite the file. Can you please help me in order to understand the issue.

If photo is placed in temp iOS storage folder then library is not able to override the file? Initially did you copied the file in temp folder?

Thanks
</ Pranav >

@RZulfikri RZulfikri mentioned this pull request Feb 13, 2019
Closed
@mysport12 mysport12 mentioned this pull request Apr 30, 2019
Merged
mysport12 added a commit to homeeondemand/react-native-photo-editor that referenced this pull request Apr 30, 2019
@mysport12
Incorporate PRs and Additional Updates (#1)
5cbf39d 
Incorporates PRs prscX#42 (which builds upon prscX#11) and prscX#51

Added prettier config
Updated Example
Updated RNPhotoEditor, simplifying and removing extraneous code
Moved podspec to the root directory
Android build config settings were updated
Listed react-native as a peerDependency
This was referenced Apr 30, 2019
Merged
Merged
@prscX
Copy link
Owner

prscX commented Jul 21, 2019

Thanks @tonimoeckel for the Effort you have added for this PR.

I have merged PR: 54 which contains this PR changes as well. Since the changes are already merged, I am closing this PR.

Thanks
</ Pranav >

@prscX prscX closed this Jul 21, 2019
Desintegrator pushed a commit to Desintegrator/react-native-photo-editor-1 that referenced this pull request Jun 10, 2022
Merge pull request prscX#11 in CLASS/react-native-photo-editor from i…
c8251bb 
…os-text-fixes to master

* commit '2eb2d6dd9c5aa835d5b6d6498d55428be99ec5dc':
  fix: update textViews + clearAll as new layer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@prscX prscX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonimoeckel @prscX