Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document the kinds of patches the repo is open to #8900

Merged
merged 3 commits into from
Oct 13, 2021
Merged

document the kinds of patches the repo is open to #8900

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c60aee6
document the kinds of patches the repo is open to
elharo Aug 24, 2021
0ba60d6
be more amenable to optimizations
elharo Oct 13, 2021
9e2b675
fix typo
elharo Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
be more amenable to optimizations
  • Loading branch information
@elharo
elharo committed Oct 13, 2021
commit 0ba60d6a8dff782d9c3f6979e97f31b2ed9eb249
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ expect contributors to follow.
conceptual burden and ongoing maintenance cost. It's best to file an issue
and get agreement from maintainers on the value of a new feature before
working on a PR.
* Performance improvements are rarely accepted. The ones that are accepted
must be heavily benchmarked in both open source and Google internal systems.
* Performance optimizations may be accepted if they have convincing benchmarks that demonstrate
an improvement and they do not signficantly increase complexity.
* Changes to existing APIs are almost never accepted. Stability and
backwards compatibility are paramount. In the unlikely event a breaking change
is required, it must usually be implemented in google3 first.
Expand Down