document the kinds of patches the repo is open to #8900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping @fowles |
fowles
reviewed
Oct 13, 2021
CONTRIBUTING.md
Outdated
| and get agreement from maintainers on the value of a new feature before | ||
| working on a PR. | ||
| * Performance improvements are rarely accepted. The ones that are accepted | ||
| must be heavily benchmarked in both open source and Google internal systems. |
There was a problem hiding this comment.
I don't think this is a fair representation. I think Performance improvements like bug fixes will be accepted with good benchmarks justifying them (assuming they do not increase complexity signficantly).
fowles
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fowles first pass at some of the content we discussed this morning