Move both examples into single Dockerfile for Docker Hub (fixes #347) #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This appears to me exactly the thing we need. However, since my Docker foo is still mediocre, it would be great if somebody else could chime in for a sanity check, for example @discordianfish . 🙏 |
grobie
approved these changes
Jul 9, 2018
Dockerfile
Outdated
| @@ -4,17 +4,20 @@ | |||
| # docker build -f examples/$name/Dockerfile -t prometheus/golang-example-$name . | |||
|
|
|||
| # Builder image, where we build the example. | |||
| FROM golang:1.9.0 AS builder | |||
| FROM golang:1.10.3 AS builder | |||
There was a problem hiding this comment.
Golang 1 has a stable and guaranteed interface, using golang:1 would remove the need to constantly update this version with every new release.
There was a problem hiding this comment.
Thanks for the feedback. Sounds good. I've updated the PR.
…theus#347) Signed-off-by: Peter Sutherland <[email protected]>
|
LGTM |
|
Thanks everybody. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be the last step to get the examples on the Docker Hub. It:
The two commands to run the examples with this change could be:
I have tested this on the hub and it does build:
See issue #347 and the discussion on #348.
Please let me know @beorn7 if you would like any changes. I can also make a PR to the docs repo to add this to the getting started guide.