Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push the simple and random examples to docker hub #347

Closed
dlespiau opened this issue Sep 6, 2017 · 4 comments
Closed

Push the simple and random examples to docker hub #347

dlespiau opened this issue Sep 6, 2017 · 4 comments
Labels
enhancement help wanted

Comments

@dlespiau
Copy link
Contributor

dlespiau commented Sep 6, 2017

It'd be nice to be able to install those two examples with docker invocations so both an instrumented daemon and prometheus can be started this way. This would allow a full end to end example with two docker run and with a config file bound mounted, which seems fairly minimal.

The labels could be:

  • prometheus/example-golang-simple
  • prometheus/example-golang-random

I can prepare a PR building the docker images, but would be good to know if people are happy with the idea.
@beorn7
Copy link
Member

beorn7 commented Sep 7, 2017

I don't feel strongly. @discordianfish does this make sense?

@discordianfish
Copy link
Member

Sounds good!

dlespiau added a commit to dlespiau/client_golang that referenced this issue Sep 11, 2017
@dlespiau
Create Docker images for the examples
dbd2945 
When those are published on Dockerhub, people will be able to start those
examples in fewer steps than the current documentation:

  https://prometheus.io/docs/introduction/getting_started/#starting-up-some-sample-targets

While relying on Docker may not be always wished, giving the possibility to
quickly start a daemon that exposes metrics can be useful in many tutorials.

This commit tries really hard to limit the number of per-example maintenance
work by sharing most of the Makefile to build the Docker images. The tiny top
level Makefiles in each example directory are strictly identical.

Updates: prometheus#347
@dlespiau dlespiau mentioned this issue Sep 11, 2017
Merged
dlespiau added a commit to dlespiau/client_golang that referenced this issue Sep 12, 2017
@dlespiau
Create Docker images for the examples
8500bb5 
When those are published on Dockerhub, people will be able to start those
examples in fewer steps than the current documentation:

  https://prometheus.io/docs/introduction/getting_started/#starting-up-some-sample-targets

While relying on Docker may not be always wished, giving the possibility to
quickly start a daemon that exposes metrics can be useful in many tutorials.

The simple and random example are build as static binaries and packaged as
single binaries in Docker images.

This commit tries really hard to limit the number of per-example maintenance
work by sharing most of the Makefile to build the Docker images. The tiny top
level Makefiles in each example directory are strictly identical.

Updates: prometheus#347
dlespiau added a commit to dlespiau/client_golang that referenced this issue Sep 19, 2017
@dlespiau
Create Docker images for the examples
dfd7b50 
When those are published on Dockerhub, people will be able to start those
examples in fewer steps than the current documentation:

  https://prometheus.io/docs/introduction/getting_started/#starting-up-some-sample-targets

While relying on Docker may not be always wished, giving the possibility to
quickly start a daemon that exposes metrics can be useful in many tutorials.

The simple and random example are build as static binaries and packaged as
single binaries in Docker images.

This commit tries really hard to limit the number of per-example maintenance
work by sharing most of the Makefile to build the Docker images. The tiny top
level Makefiles in each example directory are strictly identical.

Updates: prometheus#347
dlespiau added a commit to dlespiau/client_golang that referenced this issue Sep 19, 2017
@dlespiau
Create Docker images for the examples
296fcba 
When those are published on Dockerhub, people will be able to start those
examples in fewer steps than the current documentation:

  https://prometheus.io/docs/introduction/getting_started/#starting-up-some-sample-targets

While relying on Docker may not be always wished, giving the possibility to
quickly start a daemon that exposes metrics can be useful in many tutorials.

The simple and random example are build as static binaries and packaged as
single binaries in Docker images.

This commit tries really hard to limit the number of per-example maintenance
work by sharing most of the Makefile to build the Docker images. The tiny top
level Makefiles in each example directory are strictly identical.

Updates: prometheus#347
dlespiau added a commit to dlespiau/client_golang that referenced this issue Sep 19, 2017
@dlespiau
Create Docker images for the examples
32a4b64 
When those are published on Dockerhub, people will be able to start those
examples in fewer steps than the current documentation:

  https://prometheus.io/docs/introduction/getting_started/#starting-up-some-sample-targets

While relying on Docker may not be always wished, giving the possibility to
quickly start a daemon that exposes metrics can be useful in many tutorials.

The simple and random example are build as static binaries and packaged as
single binaries in Docker images.

This commit tries really hard to limit the number of per-example maintenance
work by sharing most of the Makefile to build the Docker images. The tiny top
level Makefiles in each example directory are strictly identical.

Updates: prometheus#347
dlespiau added a commit to dlespiau/client_golang that referenced this issue Sep 19, 2017
@dlespiau
Create Docker images for the examples
ec06aca 
When those are published on Dockerhub, people will be able to start those
examples in fewer steps than the current documentation:

  https://prometheus.io/docs/introduction/getting_started/#starting-up-some-sample-targets

While relying on Docker may not be always wished, giving the possibility to
quickly start a daemon that exposes metrics can be useful in many tutorials.

The simple and random example are build as static binaries and packaged as
single binaries in Docker images.

This commit tries really hard to limit the number of per-example maintenance
work by sharing most of the Makefile to build the Docker images. The tiny top
level Makefiles in each example directory are strictly identical.

Updates: prometheus#347
@bergquist
Copy link

bergquist commented Nov 30, 2017 •
edited
Loading

Whats the state on this? I would love to use those images in our Grafana dev environment.
So far I can only find the simple example https://hub.docker.com/r/prom/client_golang_examples_simple/

Yes. I'm to lazy to build them myself ;)

@beorn7
Copy link
Member

beorn7 commented Dec 1, 2017

See discussion on #348 . It looks we need to implement what was suggested last in the discussion on that (already merged) PR. I wanted to do it, but I have to admit I have way too many things on my plate that are much more important.
Happy to accept anything that improves things.

pedrosland added a commit to pedrosland/client_golang that referenced this issue Jul 8, 2018
@pedrosland
Move both examples into single Dockerfile for Docker Hub (fixes prome…
1c86b60 
…theus#347)
pedrosland added a commit to pedrosland/client_golang that referenced this issue Jul 8, 2018
@pedrosland
Move both examples into single Dockerfile for Docker Hub (fixes prome…
516efb1 
…theus#347)

Signed-off-by: Pedro Sland <[email protected]>
@pedrosland pedrosland mentioned this issue Jul 8, 2018
Merged
@beorn7 beorn7 closed this as completed in e9d57b3 Jul 10, 2018
beorn7 added a commit that referenced this issue Jul 10, 2018
@beorn7
Merge pull request #424 from pedrosland/test
ee1c9d7 
Move both examples into single Dockerfile for Docker Hub (fixes #347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dlespiau @discordianfish @bergquist @beorn7