This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Bump Go to 1.19.4 #571
Merged
Bump Go to 1.19.4 #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bumps golang.org/x/net to v0.4.0 and gets rid of usage of pointer functions for primitive types in favor of generic based helper Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
requested review from
stevesloka and
skriss
and removed request for
a team
Codecov ReportBase: 76.22% // Head: 74.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
- Coverage 76.22% 74.83% -1.39%
==========================================
Files 29 29
Lines 2625 2635 +10
==========================================
- Hits 2001 1972 -29
- Misses 487 519 +32
- Partials 137 144 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
skriss
previously approved these changes
Dec 15, 2022
|
probably blocked on #570 |
Signed-off-by: Sunjay Bhatia <[email protected]>
clock interface not really used properly so can get rid Signed-off-by: Sunjay Bhatia <[email protected]>
|
taking a look again at that status package, do not merge for now! |
Signed-off-by: Sunjay Bhatia <[email protected]>
done |
skriss
approved these changes
Dec 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bumps golang.org/x/net to v0.4.0 and gets rid of usage of pointer functions for primitive types in favor of generic based helper