This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Updates for Gateway API 0.6.0-rc1 #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RBAC etc. and bumps go.mod dependency Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
commented
Dec 15, 2022
| @@ -57,7 +56,7 @@ var ( | |||
| func init() { | |||
| _ = clientgoscheme.AddToScheme(scheme) | |||
| _ = operatorv1alpha1.AddToScheme(scheme) | |||
| _ = gatewayv1alpha2.AddToScheme(scheme) | |||
There was a problem hiding this comment.
didnt bother keeping this since we dont use any TLSRoutes here
Codecov ReportBase: 77.37% // Head: 75.50% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 77.37% 75.50% -1.88%
==========================================
Files 29 29
Lines 2621 2625 +4
==========================================
- Hits 2028 1982 -46
- Misses 467 505 +38
- Partials 126 138 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merged
skriss
approved these changes
Dec 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RBAC etc. and bumps go.mod dependency