Implements Contour Namespace API #25
Conversation
danehans
force-pushed
the
ns_api_impl
branch
2 times, most recently
from
06a3f12
to
aef797c
Compare
|
@stevesloka commit /cc @Miciah |
controller/contour/controller.go
Outdated
|
|
||
| // contoursExist lists Contour objects in all namespaces if all is true or only the | ||
| // namespace of contour otherwise, returning true if any exist other than contour. | ||
| func (r *Reconciler) contoursExist(ctx context.Context, contour *operatorv1alpha1.Contour, all bool) (bool, error) { |
There was a problem hiding this comment.
all is not currently specified as true anywhere, but I assume you have a plan to use it?
There was a problem hiding this comment.
I replaced this func with https://github.com/projectcontour/contour-operator/pull/21/files#diff-eee6f38bbe0411df081f7393625f732eR136-R159. I'll remove either based on which PR merges first.
danehans
force-pushed
the
ns_api_impl
branch
from
aef797c
to
c3ac3d3
Compare
|
@skriss I really appreciate the review. Commit |
|
Needs a rebase now that #19 has merged. |
Signed-off-by: Daneyon Hansen <[email protected]>
danehans
force-pushed
the
ns_api_impl
branch
from
c3ac3d3
to
58ac6b6
Compare
|
@skriss commit |
|
@stevesloka PTAL when you have a moment. |
Implements the Namespace API added in #20. Updates
ensureNamespace()andensureNamespaceRemoved()to use aContourobject instead of a namespace string as a parameter. UpdatesensureNamespaceRemoved()to only remove the namespace if RemoveOnDeletion is unset and the namespace does not match a name in namespaceBlacklist.Requires PR #24
/assign @jpeach @stevesloka
/cc @Miciah
Signed-off-by: Daneyon Hansen [email protected]