Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Adds Namespace Support to Contour API #20

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Sep 3, 2020

Adds namespace support to the Contour API type. Partially fixes issue #18.

/cc @jpeach @Miciah @stevesloka

@danehans
Copy link
Contributor Author

danehans commented Sep 3, 2020

Another option is to add the namespace name as a string and remove the namespaceSpec struct. If this option is preferred, I suggest the operator removes namespace deletion support. It may be safer for the operator to not support namespace deletion since it can cause significant side effects. Thoughts @jpeach?

@stevesloka
Copy link
Member

@danehans do you need to have namespace be a param or just create the instance of Contour in the same namespace where the CRD is created?

api/v1alpha1/contour_types.go Show resolved Hide resolved
api/v1alpha1/contour_types.go Show resolved Hide resolved
@jpeach
Copy link
Contributor

jpeach commented Sep 4, 2020

@danehans do you need to have namespace be a param or just create the instance of Contour in the same namespace where the CRD is created?

This would remove the possibility of different Contour resources specifying the same namespace. OTOH, it implies a different privilege model for being able to install Contour 🤷

@danehans
Copy link
Contributor Author

danehans commented Sep 9, 2020

@danehans do you need to have namespace be a param or just create the instance of Contour in the same namespace where the CRD is created?

@stevesloka typically an instance of the CRD, Contour in this case, exists in the same namespace as the operator and the operand(s), e.g. the Contour deployment, Envoy daemonset, etc. exist in a separate namespace (projectcontour by default). It's the operand namespace that this PR intends to address.

Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpeach jpeach merged commit 2a247e8 into projectcontour:main Sep 10, 2020
@danehans danehans deleted the ns_api branch September 14, 2020 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants