Fix python Wi-Fi/Thread setup with manual code #33933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Plumbing was missing to pass down the short discriminator - Passing `--manual-code 1234-567-8901` which only has short discriminator, would always fail to find device over BLE Fixes project-chip#26907 This PR: - Adds plumbing to detect short discriminator in Python controller - Improves code-based setup in CHIPDeviceController to honor the SetupDiscriminator value, including whether short/long. Testing done: - Ran `python3 src/python_testing/TC_SC_3_6.py --commissioning-method ble-wifi --wifi-ssid MySsid --wifi-passphrase Secret123 --manual-code 2168-374-4904 --storage-path kvs1` - Before fix, discriminator always mismatched. - After fix, commissioning succeeds. - Unit tests and other integration tests still pass
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33933: Size comparison from a12a0c0 to df49964 Full report (22 builds for cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
bzbarsky-apple
approved these changes
Jun 14, 2024
|
PR #33933: Size comparison from a12a0c0 to 1aa93d0 Full report (4 builds for cc32xx, mbed, stm32)
|
|
PR #33933: Size comparison from a12a0c0 to 7399c9a Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jun 14, 2024
agners
added a commit
to home-assistant-libs/chip-wheels
that referenced
this pull request
Jun 17, 2024
This adds more cleanups from the master branch to keep our 1.3 based branch close to upstream. Most noteworthy here are a patch which stops mDNS discovery when using the on-network commissioning API, fixes when commissioning using WiFi/Thread setup through BLE directly (the Python Matter Server isn't using this APIs currently), dropping unnecessary code and and general messaging cleanup. Specifically, this integrates changes from the following PRs - project-chip/connectedhomeip#33882 - project-chip/connectedhomeip#33896 - project-chip/connectedhomeip#33891 - project-chip/connectedhomeip#33880 - project-chip/connectedhomeip#33914 - project-chip/connectedhomeip#33915 - project-chip/connectedhomeip#33933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--manual-code 1234-567-8901which only has short discriminator, would always fail to find device over BLEFixes #26907
This PR:
Testing done:
python3 src/python_testing/TC_SC_3_6.py --commissioning-method ble-wifi --wifi-ssid MySsid --wifi-passphrase Secret123 --manual-code 2168-374-4904 --storage-path kvs1