-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid errors when using on-network commissioning #33880
Merged
mergify
merged 1 commit into
project-chip:master
from
agners:improve-on-network-commissioning
Jun 13, 2024
Merged
Avoid errors when using on-network commissioning #33880
mergify
merged 1 commit into
project-chip:master
from
agners:improve-on-network-commissioning
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33880: Size comparison from 2d97cda to ed081b5 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Jun 12, 2024
When on network commissioning is used from Python we currently don't stop discovery even though we already found a device. Future devices found won't be processed, so it is fine to stop discovery of commissionable nodes at this point. Also avoid "Unknown filter type; all matches will fail" errors in the log: If the filter type is set to None, it wasn't the SetUpCodePairer which set up the discovery. Avoid printing errors in this case. A potential alternative to this would be to skip notifying the SetUpCodePairer in DeviceCommissioner::OnNodeDiscovered in this case.
ed081b5
to
45e6568
Compare
PR #33880: Size comparison from bbd3419 to 45e6568 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
agners
added a commit
to home-assistant-libs/chip-wheels
that referenced
this pull request
Jun 17, 2024
This adds more cleanups from the master branch to keep our 1.3 based branch close to upstream. Most noteworthy here are a patch which stops mDNS discovery when using the on-network commissioning API, fixes when commissioning using WiFi/Thread setup through BLE directly (the Python Matter Server isn't using this APIs currently), dropping unnecessary code and and general messaging cleanup. Specifically, this integrates changes from the following PRs - project-chip/connectedhomeip#33882 - project-chip/connectedhomeip#33896 - project-chip/connectedhomeip#33891 - project-chip/connectedhomeip#33880 - project-chip/connectedhomeip#33914 - project-chip/connectedhomeip#33915 - project-chip/connectedhomeip#33933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When on network commissioning is used from Python we currently don't stop discovery even though we already found a device. Future devices found won't be processed, so it is fine to stop discovery of commissionable nodes at this point.
This effectively aligns behavior with SetUpCodePairer when
kDiscoveryNetworkOnlyWithoutPASEAutoRetry
is used.Also avoid "Unknown filter type; all matches will fail" errors in the log: If the filter type is set to None, it wasn't the SetUpCodePairer which set up the discovery. Avoid printing errors in this case.
A potential alternative to this would be to skip notifying the SetUpCodePairer in
DeviceCommissioner::OnNodeDiscovered
in this case.