Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use argv-iterator #16

Merged
merged 13 commits into from
Oct 31, 2022
Prev Previous commit
Next Next commit
refactor
  • Loading branch information
privatenumber committed Oct 31, 2022
commit f0b668ea91f2a90e4ffadb591c7b47f0a910a46c
31 changes: 30 additions & 1 deletion src/argv-iterator.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {
DOUBLE_DASH,
parseFlagArgv,
} from './utils';

type BreakIteration = false;
Expand All @@ -26,6 +25,36 @@ type onEndOfFlags = (
index: number,
) => void

const valueDelimiterPattern = /[.:=]/;

const isFlagPattern = /^-{1,2}[\da-z]/i;

const parseFlagArgv = (
flagArgv: string,
): [
flagName: string,
flagValue: string | undefined,
isAlias: boolean,
] | undefined => {
if (!isFlagPattern.test(flagArgv)) {
return;
}

const isAlias = !flagArgv.startsWith(DOUBLE_DASH);
let flagName = flagArgv.slice(isAlias ? 1 : 2);

let flagValue;

const hasValueDalimiter = flagName.match(valueDelimiterPattern);
if (hasValueDalimiter?.index) {
const equalIndex = hasValueDalimiter.index;
flagValue = flagName.slice(equalIndex + 1);
flagName = flagName.slice(0, equalIndex);
}

return [flagName, flagValue, isAlias];
};

export const argvIterator = (
argv: string[],
callbacks: {
Expand Down
103 changes: 26 additions & 77 deletions src/type-flag.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
import type {
Flags,
FlagTypeOrSchema,
TypeFlag,
} from './types';
import {
DOUBLE_DASH,
kebabToCamel,
createFlagsObject,
mapAliases,
createRegistry,
normalizeBoolean,
applyParser,
setDefaultFlagValues,
parseFlagType,
hasOwn,
getOwn,
} from './utils';
Expand Down Expand Up @@ -53,86 +48,42 @@ export const typeFlag = <Schemas extends Flags>(
} = {},
) => {
const { ignoreUnknown } = options;
const aliasesMap = mapAliases(schemas);
const [flagRegistry, flags] = createRegistry(schemas);
const parsed: ParsedFlags = {
flags: createFlagsObject(schemas),
flags,
unknownFlags: {},
_: Object.assign([], {
[DOUBLE_DASH]: [],
}),
};

const setKnown = (
flagName: string,
flagSchema: FlagTypeOrSchema,
explicitValue?: string,
) => {
const [flagType] = parseFlagType(flagSchema);
const flagValue = normalizeBoolean(flagType, explicitValue);

const setValueOnPreviousFlag = (value?: string | boolean) => {
const parsedValue = applyParser(flagType, value || '');
const flagsArray = parsed.flags[flagName];
if (Array.isArray(flagsArray)) {
flagsArray.push(parsedValue);
} else {
parsed.flags[flagName] = parsedValue;
}
};

return (
flagValue === undefined
? setValueOnPreviousFlag
: setValueOnPreviousFlag(flagValue)
);
};

const setUnknown = (
flagName: string,
explicitValue?: string,
) => {
if (!hasOwn(parsed.unknownFlags, flagName)) {
parsed.unknownFlags[flagName] = [];
}

parsed.unknownFlags[flagName].push(
explicitValue === undefined ? true : explicitValue,
);
};

argvIterator(argv, {
onFlag(name, value, index) {
if (name.length === 1) {
const hasAlias = getOwn(aliasesMap, name);
if (hasAlias) {
return setKnown(
hasAlias.name,
hasAlias.schema,
value,
);
} if (ignoreUnknown) {
parsed._.push(argv[index]);
} else {
setUnknown(name, value);
}
onFlag(name, explicitValue, index) {
const knownFlag = getOwn(flagRegistry, name);

if (knownFlag) {
const [parser, values] = knownFlag;
const flagValue = normalizeBoolean(parser, explicitValue);
const getFollowingValue = (value?: string | boolean) => {
const parsedValue = applyParser(parser, value || '');
values.push(parsedValue);
};

return (
flagValue === undefined
? getFollowingValue
: getFollowingValue(flagValue)
);
} if (ignoreUnknown) {
parsed._.push(argv[index]);
} else {
let flagSchema = getOwn(schemas, name);
if (!flagSchema) {
const camelized = kebabToCamel(name);
flagSchema = getOwn(schemas, camelized);

if (flagSchema) {
name = camelized;
}
if (!hasOwn(parsed.unknownFlags, name)) {
parsed.unknownFlags[name] = [];
}

if (flagSchema) {
return setKnown(name, flagSchema, value);
} if (ignoreUnknown) {
parsed._.push(argv[index]);
} else {
setUnknown(name, value);
}
parsed.unknownFlags[name].push(
explicitValue === undefined ? true : explicitValue,
);
}
},

Expand All @@ -147,8 +98,6 @@ export const typeFlag = <Schemas extends Flags>(
},
});

setDefaultFlagValues(schemas, parsed.flags);

type Result = TypeFlag<Schemas>;
return parsed as {
// This exposes the content of "TypeFlag<T>" in type hints
Expand Down
Loading