Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use argv-iterator #16

Merged
merged 13 commits into from
Oct 31, 2022
Merged

refactor: use argv-iterator #16

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9203910
refactor: use argv-iterator
privatenumber Oct 31, 2022
6c2090e
Merge branch 'develop' of github.com:privatenumber/type-flag into arg…
privatenumber Oct 31, 2022
f0b668e
refactor
privatenumber Oct 31, 2022
789dc45
Merge branch 'develop' of github.com:privatenumber/type-flag into arg…
privatenumber Oct 31, 2022
90b1e35
Merge branch 'develop' of github.com:privatenumber/type-flag into arg…
privatenumber Oct 31, 2022
00f4add
refactor
privatenumber Oct 31, 2022
fcb7490
refactor
privatenumber Oct 31, 2022
2571af4
refactor
privatenumber Oct 31, 2022
9adab97
refactor
privatenumber Oct 31, 2022
ba73bf1
refactor
privatenumber Oct 31, 2022
cd2569f
refactor
privatenumber Oct 31, 2022
8e23bdb
refactor
privatenumber Oct 31, 2022
fc803bf
refactor
privatenumber Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor
  • Loading branch information
@privatenumber
privatenumber committed Oct 31, 2022
commit 8e23bdb020ce628d55922cb58d0dbe097aff7aa0
8 changes: 4 additions & 4 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export const createRegistry = (
const schema = schemas[flagName];
const [parser, isArray] = parseFlagType(schema);
const values: unknown[] = [];
const asdf = [parser, values];
const flagData = [parser, values];

Object.defineProperty(flags, flagName, {
enumerable: true,
Expand All @@ -134,11 +134,11 @@ export const createRegistry = (
},
});

setFlag(flagName, asdf);
setFlag(flagName, flagData);

const kebabCasing = camelToKebab(flagName);
if (flagName !== kebabCasing) {
setFlag(kebabCasing, asdf);
setFlag(kebabCasing, flagData);
}

if ('alias' in schema && typeof schema.alias === 'string') {
Expand All @@ -153,7 +153,7 @@ export const createRegistry = (
throw new Error(`${errorPrefix} must be a single character`);
}

setFlag(alias, asdf);
setFlag(alias, flagData);
}
}

Expand Down