-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin api #1387
Comments
Using the id string allows to overwrite a plugin, eg by providing a different mapreduce plugin - but I'm also unhappy with those otherwise useless strings. And, while we're at it (and motivated by the generality of this ticket): With our current plugin system this is not possible because they are exclusively, meaning the last installed plugin provides the method. Maybe the plugin could just receive the old api? |
Well specifying the name of the method (IE query instead of MapReduce)
|
yes, thats right. Shouldn't it be possible to specify more than one method? // eg
PouchDB.plugin(constructor, ["query", "find"]);
// or
PouchDB.plugin(constructor, "query", "find"); |
While we're at it, #1118 is still a low-hanging fruit. Would probably really help with all the goodfirstpatch/goodstudentproject stuff. |
so now that the prototype one landed, we could have a new style plugin, which we just add to PouchDB.prototype |
currently the api is
"string we never use", constructor
and all the methods on the returned object get merged. Something more like "method name", constructor might be bettera third argument could be the name of the export method
The text was updated successfully, but these errors were encountered: