Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Name field to the Identity struct #96

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

kenjenkins
Copy link
Contributor

As of v0.18, the Pomerium JWT will include a 'name' claim by default (if supported by the identity provider). Add a corresponding field to the sdk.Identity struct.

Fixes #93.

As of v0.18, the Pomerium JWT will include a 'name' claim by default (if
supported by the identity provider). Add a corresponding field to the
sdk.Identity struct.
@kenjenkins kenjenkins requested a review from a team as a code owner June 14, 2023 22:36
@kenjenkins kenjenkins requested review from calebdoxsey and removed request for a team June 14, 2023 22:36
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #96 (3fe2041) into main (58bc403) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #96   +/-   ##
=====================================
  Coverage   72.6%   72.6%           
=====================================
  Files          3       3           
  Lines        205     205           
=====================================
  Hits         149     149           
  Misses        38      38           
  Partials      18      18           
Impacted Files Coverage Δ
sdk.go 71.5% <ø> (ø)

@kenjenkins kenjenkins merged commit 223105b into main Jun 14, 2023
@kenjenkins kenjenkins deleted the kenjenkins/name-claim branch June 14, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: include "name" claim in Identity struct
2 participants