Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: include "name" claim in Identity struct #93

Closed
kenjenkins opened this issue Jun 5, 2023 · 1 comment · Fixed by #96
Closed

Feature request: include "name" claim in Identity struct #93

kenjenkins opened this issue Jun 5, 2023 · 1 comment · Fixed by #96
Labels
documentation Improvements or additions to documentation

Comments

@kenjenkins
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It looks like the Pomerium JWT will include a "name" claim by default, as of pomerium/pomerium#3238. However the sdk.Identity struct does not yet have a Name field, so there's no easy way to access this claim using the SDK.

Describe the solution you'd like

Let's add a field for this claim to the sdk.Identity struct.

Describe alternatives you've considered

n/a

Explain any additional use-cases

n/a

Additional context

It looks like someone has forked this repository in order to add a Name field: mworzala@003caf5#diff-09f9b3a1799ba8820fa8a377f22a680365e56db8ea8dab214280822f6327c01f

@desimone
Copy link
Contributor

desimone commented Jun 8, 2023

Added in

Looks like we also need to update docs entries as well beyond just the grafana guide e.g.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants