Node 12 fixes follow-up #27

petrzjunior · 2020-01-24T21:27:57Z

Now working with Node.js versions 8.x up to 13.x!

update to Bindings 1.5.0
update to Nan 2.14.0
use Nan::To<> for type conversions
use Nan::GetFunction and Nan::Set to retain cross-compatibility
provide Nan::AsyncResource to callback as required by new version of Nan library
fix all compiler warnings

There are currently no compiler warnings and code uses no deprecated functions anymore. 🎉

pokusew · 2020-01-25T22:15:57Z

@petrzjunior Thank you very much for your PR. I really appreciate the work you did on this. 👍

This was referenced Jan 24, 2020

Node 12 fixes #26

Merged

remove deprecated v8::Handle to upgrade to node@12 #23

Closed

petrzjunior force-pushed the node12fix branch from 883ba70 to 4ee6d68 Compare January 25, 2020 15:18

Use Nan wrapper for type conversion

9cc6135

petrzjunior force-pushed the node12fix branch from 4ee6d68 to 8483100 Compare January 25, 2020 15:27

petrzjunior added 3 commits January 25, 2020 16:55

Use Nan::Set in all places

0f3ff2c

Provide AsyncResource

f300d5e

Fix compiler warnings

acb4e85

petrzjunior force-pushed the node12fix branch from 8483100 to acb4e85 Compare January 25, 2020 15:58

pokusew merged commit 907f54b into pokusew:master Jan 25, 2020

petrzjunior deleted the node12fix branch January 26, 2020 10:29

pokusew mentioned this pull request Feb 25, 2020

SCARD_SCOPE_USER is probably safer #30

Open

Provide feedback