Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12 fixes #26

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Node 12 fixes #26

merged 1 commit into from
Jan 24, 2020

Conversation

jimmythesaint82
Copy link

All node 12 fixes

@Stunc0
Copy link

Stunc0 commented Sep 13, 2019

Does this package is still maintained ? Cause i see that this pull request is there since many months ...

@gjreasoner
Copy link

For anyone on node12 you can install this PR w/ this command:

npm install pokusew/node-pcsclite#pull/26/head

@Stunc0
Copy link

Stunc0 commented Sep 20, 2019

npm install pokusew/node-pcsclite#pull/26/head

I still have many issues during the npm install with this one. Because i need to "node-gyp rebuild"...
And during the rebuild i have a lot of warning
TinyGrab Screen Shot 20-09-2019 10 53 08

@jorispz
Copy link

jorispz commented Oct 25, 2019

I've installed from this branch successfully on raspbian, thanks @jimmythesaint82

@pokusew any change of this getting merged for a proper release?

@janhon3n
Copy link

I've managed to get it working with electron 6.1.7, but with version 7 the electron-rebuild fails with similar interface errors. The node version is upgraded in the release from 12.4.0 to 12.8.1 . Any ideas how to fix?

@Stunc0
Copy link

Stunc0 commented Jan 24, 2020

I'm not using this one anymore but with the original pcsclite 1.0.0. And it works actually with electron 7.1.7 and node 12.14.1. Have you tried an npm rebuild ?

@pokusew pokusew merged commit 8af0548 into pokusew:master Jan 24, 2020
@pokusew
Copy link
Owner

pokusew commented Jan 24, 2020

Hi @jimmythesaint82,

Thank you very much for your PR. I really appreciate the work you did. 👍

I am really sorry it look me so long to review and merge it.

However, during the last months, more breaking changes in the Node.js and especially in the nan wrapper methods emerged, so the changes in this PR are longer sufficient in the newest Node.js 12 (and 13).

Now I am working with @petrzjunior to prepare a series of follow-up changes (#27) that should make this package fully compatible with Node.js 12 and 13 and also replace legacy nan usages with the current best practices. I expect a new release containing these fixes and improvements in about a week.

Thanks again for your contributions. 🙂

cc @Stunc0, @gjrdiesel, @jorispz, @janhon3n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants