Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 12 / electron 5 compat #81

Closed
zy4 opened this issue May 2, 2019 · 2 comments · Fixed by pokusew/node-pcsclite#27
Closed

node 12 / electron 5 compat #81

zy4 opened this issue May 2, 2019 · 2 comments · Fixed by pokusew/node-pcsclite#27
Labels
compatibilty: Node.js 11+ Issues related to the incompatibility with the current Node.js versions

Comments

@zy4
Copy link

zy4 commented May 2, 2019

pokusew/node-pcsclite#23
@bashoogzaad
Copy link

I also have the issue that electron-rebuild is failing because of v8 Handle being removed from Electron 5.

@petrzjunior petrzjunior mentioned this issue Jan 25, 2020
Merged
@pokusew pokusew added the compatibilty: Node.js 11+ Issues related to the incompatibility with the current Node.js versions label Jan 25, 2020
@pokusew
Copy link
Owner

pokusew commented Jan 26, 2020

@zy4 @bashoogzaad Fixed and released in version 0.8.0. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibilty: Node.js 11+ Issues related to the incompatibility with the current Node.js versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Node 12 fixes follow-up petrzjunior/node-pcsclite
3 participants
@pokusew @bashoogzaad @zy4