Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8206: playwright tests for MS Edge sidebar links #8216

Merged
merged 24 commits into from
May 15, 2024
Merged

#8206: playwright tests for MS Edge sidebar links #8216

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
e52a302
#8206: playwright tests for links
twschiller Apr 10, 2024
0fd07f4
Open the extension console
twschiller Apr 10, 2024
5be8e0e
Fix jest snapshots
twschiller Apr 10, 2024
ea293d0
Merge branch 'main' into feature/8206-playwright
mnholtz Apr 10, 2024
5a680e0
Add commentary on MS Edge behavior and try to fix
twschiller Apr 11, 2024
95b9b86
#8206: add more comments on playwright issues
twschiller Apr 11, 2024
dd12bd2
Merge branch 'main' into feature/8206-playwright
grahamlangford May 9, 2024
074fb91
Merge branch 'main' into feature/8206-playwright
fungairino May 9, 2024
591279f
Work around msedge bugs
fungairino May 9, 2024
5e48708
Merge branch 'main' into feature/8206-playwright
fungairino May 9, 2024
011345d
fix snapshots
fungairino May 10, 2024
4085536
Merge branch 'main' into feature/8206-playwright
fungairino May 10, 2024
f9bd5c6
wip
fungairino May 10, 2024
d74be30
fix snapshots
fungairino May 10, 2024
a1b896a
always reopen sidebar
fungairino May 10, 2024
3e0ae08
wip
fungairino May 13, 2024
1b1e7cf
fix e2e flakiness with deleting mods cleanup
fungairino May 13, 2024
49a0bf2
Merge branch 'main' into feature/8206-playwright
fungairino May 14, 2024
1fc3eb6
Merge branch 'main' into feature/8206-playwright
fungairino May 14, 2024
021a913
lint fix
fungairino May 14, 2024
309c6bc
skip iframe link test in linux
fungairino May 15, 2024
40cb8eb
fix os check
fungairino May 15, 2024
3740af7
fix os check
fungairino May 15, 2024
4b6bbed
fix osname check
fungairino May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix jest snapshots
  • Loading branch information
@twschiller
twschiller committed Apr 10, 2024
commit 5be8e0e3ca9c86705156a970498033b613d6470f
2 changes: 1 addition & 1 deletion end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ test("8206: clicking links doesn't crash browser", async ({

// FIXME: get these selectors working
// PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
// const pixiebrixFrame = page.frameLocator("iframe").first();
// const pixiebrixFrame = sideBarPage.frameLocator("iframe").first();
// const mainFrame = pixiebrixFrame.frameLocator("iframe").first();
// await expect(mainFrame.getByText("Alpha")).toBeVisible();
//
Expand Down
2 changes: 2 additions & 0 deletions src/sidebar/__snapshots__/Header.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/sidebar/__snapshots__/SidebarBody.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.