Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8206: playwright tests for MS Edge sidebar links #8216

Merged
merged 24 commits into from
May 15, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix osname check
  • Loading branch information
fungairino committed May 15, 2024
commit 4b6bbede5d9ff2e3145745df44795a42c187c483
2 changes: 1 addition & 1 deletion end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
// https://github.com/microsoft/MicrosoftEdge-Extensions/issues/145
// For some reason this also happens in Chrome/Linux in the CI github workflow.
// eslint-disable-next-line playwright/no-conditional-in-test -- see above comment
if (browserOSName !== "Linux" || chromiumChannel !== "msedge") {
if (browserOSName !== "Linux" && chromiumChannel !== "msedge") {
await test.step("Clicking link in IFrame", async () => {
// PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
const pixiebrixFrame = sideBarPage.frameLocator("iframe").first();
Expand Down
Loading