Implemented "--unattended" option (Issue #223) #224

EWouters · 2017-03-13T07:20:16Z

I ported the functionality from the pi-hole script to fix #223 (#86). I finished implementing it but more people should try it before merging.

Parameters will be stored in /etc/pivpn/setupVars.conf
added a finalExports function
added an update_dialogs function to ask what to do if a parameter file was found
added an updatePiVPN function

Moved some stuff around.

This request is ready for testing.

Due to discontinuation of Google Spaces

UNTESTED!

Merging changes into test branch

EWouters · 2017-03-13T21:53:25Z

auto_install/install.sh

+ confNetwork
+ confOVPN
+
+ # ?? Is this always OK? Also if you only select one DNS server ??


Is this always OK? Also if you only select one DNS server, i.e. OVPNDNS2 is empty?

EWouters · 2017-03-13T21:54:12Z

auto_install/install.sh

+}
+
+
+# I suggest replacing some of these names.


I suggest replacing some of these names. It looks cleaner in the parameter file.

EWouters · 2017-03-13T21:54:42Z

auto_install/install.sh

+ echo "pivpnUser=${pivpnUser}"
+ echo "UNATTUPG=${UNATTUPG}"
+ echo "pivpnInterface=${pivpnInterface}"
+ echo "IPv4dns=${IPv4dns}"


Should we save IPv4dns? Or is it fine to just detect it?

EWouters · 2017-03-13T21:57:23Z

Is there a way to update without generating new keys? I read the wiki about just not updating, but it might be a good time to add this now.

fixed a typo replaced tabs with spaces

I am not sure why this statement does not work with -e. We can also remove the set -e statement altogether.

::: Create a client ovpn profile, optional nopass ::: ::: Usage: pivpn <-a|add> [-n|--name <arg>] [-p|--password <arg>]|[nopass] [-h|--help] ::: ::: Commands: ::: nopass Create a client without a password ::: -n,--name Name for the Client (default: 'raspberrypi') ::: -p,--password Password for the Client (no default) ::: -h,--help Show this help dialog

::: Revoke a client ovpn profile ::: ::: Usage: pivpn <-r|revoke> [-h|--help] [<client-1>] ... [<client-n>] ... ::: ::: Commands: ::: [none] Interactive mode ::: <client> Client(s) to to revoke ::: -h,--help Show this help dialog

because it is hardcoded as "server" in other scripts

EWouters · 2017-03-14T13:48:19Z

I also added command line options for the pivpn add and pivpn revoke functions. Now I can fully automate the setup and send myself an email with the certificate when everything is installed. :)

As described in pivpn#165 ( fc14664) it is not desirable.

EWouters · 2017-03-15T21:00:49Z

Can anyone help me updating the bash-completion file?

…o the script

…ists

0-kaladin · 2017-04-03T22:01:38Z

@EWouters man I just saw this now. been really swamped. Let me review and give you some comments but thanks a ton for this.

0-kaladin · 2017-04-04T00:34:51Z

@EWouters this is looking good so far. I've only looked at it online. Will test on real devices to see if it broke anything somewhere. But looks good reading it, awesome job.

0-kaladin

Still looking good. will merge into test so I can do more live testing.

EWouters · 2017-04-07T19:03:57Z

Great, I'm happy to make any improvements you might suggest. There are also still a few comments in the code where I wasn't sure what was the best approach.

troyfontaine · 2018-06-10T20:37:20Z

Any word on this PR? Movement seems to have stalled?

EWouters · 2018-07-05T01:09:49Z

Hi @troyfontaine ,

The code was tested and merged into the master, and most of the suggestions and things I was not sure about have since been fixed or became obsolete. Only a few things (like the bash-completion file and the comment on this line) remain to be fixed/checked, but I don't know how to do that.

Are you referring to anything specific? And have you tried the --unattended option?

Anyway it might be a good idea to check if there were any substantial improvements in the pi-hole installer since this rewrite. I basically ported all the things they did there to this installer.

0-kaladin and others added 5 commits February 5, 2017 14:30

Leave the loop once we match

752d0cc

Update README for IRC channel

6ce39bf

Due to discontinuation of Google Spaces

Added pi-hole's undocumented flags

5db2318

UNTESTED!

Added all parameters, initial testing done

71021d6

Merge pull request #1 from EWouters/master

f050f82

Merging changes into test branch

EWouters mentioned this pull request Mar 13, 2017

Add "--unattended" option #223

Closed

EWouters added 2 commits March 14, 2017 10:48

Fixed sed command and mkdir if folder exists

2a639e7

Merge remote-tracking branch 'refs/remotes/origin/master' into test

f48225a

EWouters commented Mar 13, 2017

View reviewed changes

EWouters added 7 commits March 14, 2017 14:26

fix: cp: cannot stat ‘/tmp/pivpnINT’: No such file

5b5129f

Moved echo to file statements to front, add missing

7315353

fixed a typo replaced tabs with spaces

set -e and set +e around line 800 to 815

0971453

I am not sure why this statement does not work with -e. We can also remove the set -e statement altogether.

tabs to spaces

277a212

added command line option to (batch) remove certs

56f24aa

::: Revoke a client ovpn profile ::: ::: Usage: pivpn <-r|revoke> [-h|--help] [<client-1>] ... [<client-n>] ... ::: ::: Commands: ::: [none] Interactive mode ::: <client> Client(s) to to revoke ::: -h,--help Show this help dialog

Removed SERVER_NAME parameter

75b7995

because it is hardcoded as "server" in other scripts

Removed -p flag to create home dir

27c34aa

As described in pivpn#165 ( fc14664) it is not desirable.

EWouters added 3 commits March 16, 2017 22:25

fixed check for when both nopass and a password argument are passed t…

cd4d136

…o the script

added fi to if-statement

cb482d6

Fix: mkdir: cannot create directory ‘/home/$pivpnUser/ovpns’: File ex…

ff97f40

…ists

0-kaladin requested review from 0-kaladin and redfast00 April 4, 2017 00:33

0-kaladin approved these changes Apr 5, 2017

View reviewed changes

0-kaladin merged commit c907a4b into pivpn:test Apr 5, 2017

jellemdekker mentioned this pull request Jul 9, 2017

Unattended Install #86

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented "--unattended" option (Issue #223) #224

Implemented "--unattended" option (Issue #223) #224

EWouters commented Mar 13, 2017 •

edited

Loading

EWouters Mar 13, 2017

EWouters Mar 13, 2017 •

edited

Loading

EWouters Mar 13, 2017 •

edited

Loading

EWouters commented Mar 13, 2017

EWouters commented Mar 14, 2017

EWouters commented Mar 15, 2017

0-kaladin commented Apr 3, 2017

0-kaladin commented Apr 4, 2017

0-kaladin left a comment

EWouters commented Apr 7, 2017

troyfontaine commented Jun 10, 2018

EWouters commented Jul 5, 2018 •

edited

Loading

Implemented "--unattended" option (Issue #223) #224

Implemented "--unattended" option (Issue #223) #224

Conversation

EWouters commented Mar 13, 2017 • edited Loading

EWouters Mar 13, 2017

Choose a reason for hiding this comment

EWouters Mar 13, 2017 • edited Loading

Choose a reason for hiding this comment

EWouters Mar 13, 2017 • edited Loading

Choose a reason for hiding this comment

EWouters commented Mar 13, 2017

EWouters commented Mar 14, 2017

EWouters commented Mar 15, 2017

0-kaladin commented Apr 3, 2017

0-kaladin commented Apr 4, 2017

0-kaladin left a comment

Choose a reason for hiding this comment

EWouters commented Apr 7, 2017

troyfontaine commented Jun 10, 2018

EWouters commented Jul 5, 2018 • edited Loading

EWouters commented Mar 13, 2017 •

edited

Loading

EWouters Mar 13, 2017 •

edited

Loading

EWouters Mar 13, 2017 •

edited

Loading

EWouters commented Jul 5, 2018 •

edited

Loading