Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes/hacks for RaspPi wheezy #165

Closed
wants to merge 5 commits into from
Closed

Some fixes/hacks for RaspPi wheezy #165

wants to merge 5 commits into from

Conversation

bglnelissen
Copy link
Contributor

PRETTY_NAME="Raspbian GNU/Linux 7 (wheezy)"
NAME="Raspbian GNU/Linux"
VERSION_ID="7"
VERSION="7 (wheezy)"
ID=raspbian
ID_LIKE=debian

@bglnelissen
fixed wget command
b632e69 
wget was targeted to a directory instead of a file
@bglnelissen
fixed easyrsa install
939cd55 
wget command does not work and throws an error. "/tmp/EasyRSA-3.0.1-pivpn1/: Is a directory"
This is because the the output of wget is a directory, not a file. -O expects a file.
BN also, mv throws an error: "mv: cannot move `/tmp/EasyRSA-3.0.1-pivpn1' to `/etc/openvpn/easy-rsa': No such file or directory"
We can do a mkdir & wget & tar and move to do it in lesser steps, although less readable there are is no need for /tmp
@bglnelissen
hacked a non-existing homedir.
fc14664
@bglnelissen
fixed download location
1f0819e 
fixed easy-rsa download location
bglnelissen
bglnelissen commented Dec 8, 2016
View reviewed changes
Copy link
Contributor Author

@bglnelissen bglnelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, never used git befor, so if I have done a horrible thing let me know ;)

0-kaladin
0-kaladin approved these changes Dec 8, 2016
View reviewed changes
Copy link
Member

@0-kaladin 0-kaladin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, surprised my wget didn't complain about this. Good catch. Maybe the older version on wheezy is less tolerant.

@0-kaladin
Copy link
Member

First, thanks for contributing! Def could use more eyes and more people testing esp on stuff I don't test, like wheezy.
So a few comments:
your 'fixed wget command' b632e69
is safe to merge. my code didn't complain to me but I agree it is incorrect, my only thought is maybe the older wget in wheezy is less tolerant of errors?

then your fixed easyrsa install commit which results in bad dir you fixed with the fixed download location commit. So I'd like to add that as well.

The homedir one I do not want. Here's why:
The vast majority have a user account with a home dir. by default raspian comes with one. The default process to create any user will also create the users home dir. if they have a user without a home dir then chances are that user can't login (it may have a different case). Regardless the only real purpose of dropping ovpn files there is for easy user file transfer which won't be that easy if user has no home dir. What I would prefer to do for this edge case is actually only show users with home dirs. if it doesn't see any then prompt user to create one (with a home dir) which it will do today if it detects no normal users. so for now, cause i don't have time to implement that, can you drop this commit?

Also I'd love if you can submit this to the test branch. Basically fork from my test branch, give me the 'fixed wget command' and the 'fixed download location' change and I can merge them into test.

then we can test install from the test branch to ensure nothing broke with
curl -L http:https://install-test.pivpn.io | TESTING=1 bash

@0-kaladin
Copy link
Member

I don't have much time and wanted to get this into the test branch for testing so you'll see i was able to cherry-pick what i wanted from you in there. If you can confirm an install from test branch works for you then I will merge to master. (except the home dir thing)

@0-kaladin 0-kaladin closed this Dec 8, 2016
EWouters pushed a commit to EWouters/pivpn that referenced this pull request Mar 15, 2017
Removed -p flag to create home dir
27c34aa 
As described in pivpn#165 ( fc14664) it is not desirable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0-kaladin 0-kaladin 0-kaladin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bglnelissen @0-kaladin