Add UniquePerAccountStripeObject for Plans #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
plan-per-account-upstream
branch
3 times, most recently
from
22dce96
to
2e3f173
Compare
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
+ Coverage 99.39% 99.39% +<.01%
==========================================
Files 34 34
Lines 1817 1826 +9
Branches 166 166
==========================================
+ Hits 1806 1815 +9
Misses 5 5
Partials 6 6
Continue to review full report at Codecov.
|
blueyed
changed the title
paltman
approved these changes
Nov 23, 2017
The `stripe_id` for plans is not unique by itself globally (it is not generated by Stripe), and therefore needs to be unique per account.
blueyed
force-pushed
the
plan-per-account-upstream
branch
from
4378af8
to
2ba464f
Compare
|
Rebased / adjusted migration. |
paltman
approved these changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stripe_idfor plans is not unique by itself globally (it is not generatedby Stripe), and therefore needs to be unique per account.