Coupons #506
Open
Coupons #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkolios You might want to add some documentation for this one maybe ? |
ticosax
force-pushed
the
coupons
branch
2 times, most recently
from
44a2d34
to
3977ebb
Compare
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
=========================================
+ Coverage 99.39% 99.4% +<.01%
=========================================
Files 34 34
Lines 1817 1841 +24
Branches 166 166
=========================================
+ Hits 1806 1830 +24
Misses 5 5
Partials 6 6
Continue to review full report at Codecov.
|
|
Could include/use the new base class from #513, too. |
blueyed
reviewed
Nov 23, 2017
| @@ -76,6 +77,10 @@ def test_plan_display_invoiceitem(self): | |||
| i = InvoiceItem(plan=p) | |||
| self.assertEquals(i.plan_display(), "My Plan") | |||
|
|
|||
| def test_coupon_repr(self): | |||
| c = Coupon(id=1, percent_off=25, duration="repeating", duration_in_months=3,) | |||
| self.assertEquals(repr(c), "Coupon(pk=1, valid=False, amount_off=None, percent_off=25, currency='usd', duration='repeating', livemode=False, max_redemptions=None, times_redeemed=None, stripe_id='')") | |||
There was a problem hiding this comment.
Uncommon to set id/pk manually, but ok.
|
This needs to be really synced/updated from our next branch by now. |
|
Should wait for #513 to be merged likely. |
paltman
added
the
Original
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Add support for Coupons and Discounts objects
Definition of Done (check if considered and/or addressed):