feat(select-card) #885
Merged
feat(select-card) #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would love this card. This is really missed in the different entity cards. |
|
What do you think about coloring the select too? |
piitaya
approved these changes
Jan 10, 2023
src/cards/select-card/select-card.ts
Outdated
Comment on lines
110
to
114
| <div class="actions" ?rtl=${rtl}> | ||
| <mushroom-select-option-control | ||
| .hass=${this.hass} | ||
| .entity=${entity} | ||
| ></mushroom-select-option-control> |
There was a problem hiding this comment.
Suggested change
| <div class="actions" ?rtl=${rtl}> | |
| <mushroom-select-option-control | |
| .hass=${this.hass} | |
| .entity=${entity} | |
| ></mushroom-select-option-control> | |
| <div class="actions" ?rtl=${rtl}> | |
| <mushroom-select-option-control | |
| .hass=${this.hass} | |
| .entity=${entity} | |
| ></mushroom-select-option-control> | |
| </div> |
One missing div
Cool idea, should it be a toggle or fixed? |
|
I have the code locally so I can push it. For lights and fan, the slider is colored with the icon color so we can have the same usage here. |
Sounds good to me! |
bryan-stewart
pushed a commit
to bryan-stewart/lovelace-mushroom
that referenced
this pull request
Apr 5, 2023
* initial commit * initial implementation * fixed overflow bug * bug fixes * fixed current value not loading at first * fix select overflowing to the right at some widths * select height reduced to match other mushroom cards * Update README.md * Create select.md * default entity in "add card" menu is now correct * Added Select Card pictures * fixed bug value not getting set for select entities * Color select with icon color Co-authored-by: PaoloTK <[email protected]> Co-authored-by: Paul Bottein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a select card to control select and input_select entities.
Related Issue
#873
This PR fixes or closes issue: fixes 873
Motivation and Context
SSIA
How Has This Been Tested
Demo instance and own instance.
Types of changes
Checklist