Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Select card to control select and input_select entities #873

Open
2 tasks done
PaoloTK opened this issue Nov 24, 2022 · 6 comments
Open
2 tasks done

[Feature]: Select card to control select and input_select entities #873

PaoloTK opened this issue Nov 24, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@PaoloTK
Copy link
Contributor

PaoloTK commented Nov 24, 2022

Requirements

  • I have updated Mushroom to the latest available version
  • I did a search to see if there is a similar issue or if a pull request is open.

Is your feature request related to a problem?

Mushroom cannot control select or input_select entities at the moment.

Describe the solution you'd like

Either a new "Select Card" or the ability to show a select dropdown for entity card when a select or input_select entity is selected.

@PaoloTK PaoloTK added the enhancement New feature or request label Nov 24, 2022
@piitaya
Copy link
Owner

piitaya commented Nov 24, 2022

Thank for your feature request. There are lot of non-supported entity in Mushroom and we can not add support for all the domain because for now : 1 domain = 1 card. And it's a lot a duplicate code.
You can use the more-info popup for now for this.

@PaoloTK
Copy link
Contributor Author

PaoloTK commented Nov 24, 2022

Thank for your feature request. There are lot of non-supported entity in Mushroom and we can not add support for all the domain because for now : 1 domain = 1 card. And it's a lot a duplicate code. You can use the more-info popup for now for this.

Thank you. Working on the card as we speak, PR requires an open issue on the topic so opened one.

PS: any chance you can take a look at my RGBW light PR so I can move forward with it?

@piitaya
Copy link
Owner

piitaya commented Nov 24, 2022

As I work for Nabu Casa now, there will be lot of ongoing change to the HA dashboard so I prefer to slow down the mushroom development to avoid big refactoring 😅

@PaoloTK
Copy link
Contributor Author

PaoloTK commented Nov 24, 2022

As I work for Nabu Casa now, there will be lot of ongoing change to the HA dashboard so I prefer to slow down the mushroom development to avoid big refactoring 😅

Totally understandable. At the same time, adding RGBW(W) control is, I think, something quite important and doesn't require a lot of refactoring. Nonetheless, if it cannot be implemented I'll be submitting another PR for RGBWW as well so that if people need it they can use it. Thank you for your time.

@piitaya
Copy link
Owner

piitaya commented Nov 24, 2022

I do not prefer to add additional control for now. The editor is already too cluttered, which is opposite to what I wanted to bring with Mushroom.

@PaoloTK
Copy link
Contributor Author

PaoloTK commented Nov 24, 2022

I do not prefer to add additional control for now. The editor is already too cluttered, which is opposite to what I wanted to bring with Mushroom.

I agree that a cluttered editor is bad. However, I think it's pretty trivial to only show relevant options based on the selected entity. For example, selecting an RGBW light entity would hide the "Temperature color control?" toggle. So the number of options in the editor wouldn't increase (it would actually decrease if implemented for every option).

Also, while I agree that showing too many options is not great, we're not talking about adding options for the sake of it. Being able to control the white channel(s) in a light that has them is pretty important and something everyone that has that kind of light needs to be able to do. It's not a niche feature.

@PaoloTK PaoloTK mentioned this issue Dec 5, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants