Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

busybox: add IPv6 support #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

busybox: add IPv6 support #75

wants to merge 3 commits into from

Conversation

mateuszkobak
Copy link

@mateuszkobak mateuszkobak commented Apr 17, 2024 •
edited
Loading

Description

  • Added necessary nonblocking flag for socket used in ping6, following the existing solution for ping4
  • Provided IPv6 addresses info for ifconfig
  • Made route.c compile by including net/ip6_route.h

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32-generic-qemu (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@mateuszkobak mateuszkobak mentioned this pull request Apr 17, 2024
Open
13 tasks
@mateuszkobak mateuszkobak marked this pull request as ready for review April 18, 2024 13:10
nalajcie
nalajcie reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpicks, otherwise LGTM.

busybox/22-ifconfig-ipv6.patch Outdated Show resolved Hide resolved
busybox/22-ifconfig-ipv6.patch Outdated Show resolved Hide resolved
@mateuszkobak
busybox: include net/ip6_route.h in busybox route.c
70ba099 
JIRA: COG-42
@mateuszkobak
busybox: Fix ping6
da08134 
Add nonblocking option for socket

JIRA: COG-42
@mateuszkobak
busybox: Add IPv6 support for ifconfig
bba10b4 
Change the way ifconfig obtains the IPv6 addresses

JIRA: COG-42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalajcie nalajcie nalajcie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mateuszkobak @nalajcie