Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IPv6 #355

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Add support for IPv6 #355

merged 1 commit into from
Jun 14, 2024

Conversation

mateuszkobak
Copy link
Contributor

@mateuszkobak mateuszkobak commented Apr 15, 2024

Description

Adding features needed to compile and run ifconfig and ping with IPv6 on Busybox.

  • net/ip6_route.h is there for Busybox route.c to compile when IPv6 is enabled. The routes for IPv6 are not implemented yet.
  • netinet/icmp6.h is essential for ping in Busybox to work
  • changes in netinet/in.h and sys/sockdefs.h are used by ping in Busybox
  • changes in net/route.h are there so that route in Busybox compiles
  • changes in net/if_arp.h are there so that ifconfig in Busybox compiles

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32 (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

include/net/if_arp.h Outdated Show resolved Hide resolved
include/net/ip6_route.h Outdated Show resolved Hide resolved
include/sys/sockdefs.h Outdated Show resolved Hide resolved
include/sys/sockdefs.h Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Apr 15, 2024

Unit Test Results

7 460 tests   6 745 ✅  37m 27s ⏱️
  420 suites    715 💤
    1 files        0 ❌

Results for commit 052023c.

♻️ This comment has been updated with latest results.

Add netinet/icmp6.h
Add net/ip6_route.h -- routes for IPv6 are not implemented yet,
	but this is necessary for the busybox to compile
Add other defines needed to supposrt IPv6 in ping and ifconfig in busybox

JIRA: COG-42
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a careful review but I don't see any potentially breaking changes.

@nalajcie nalajcie requested a review from Darchiv June 13, 2024 14:18
@Darchiv Darchiv merged commit d5ee714 into master Jun 14, 2024
30 checks passed
@Darchiv Darchiv deleted the mateuszkobak/ipv6 branch June 14, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants