-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simpler rotations #2
Labels
enhancement
New feature or request
Comments
Closed
Merged
semicuda
pushed a commit
to semicuda/ikea-led-obegraensad
that referenced
this issue
Dec 3, 2023
update from ph1p
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While reading through your work (THANK YOU! ❤️ ) to understand the scan pattern, I noticed that there could be some room for making things easier to maintain and bringing support for flipping.
Instead of mutating the position array, you could do a fast transformation matrix multiplication during rendering. Bonus: the same transformation matrix can also be used for horizontal/vertical flipping.
Here's how I use a transformation matrix in my FREKVENS hack:
https://github.com/atesgoral/node-omega-frekvens/blob/master/lib/frekvens/src/OmegaDriver.cpp#L51-L58
And here's how that transformation matrix is set up, based on rotation and flip:
https://github.com/atesgoral/node-omega-frekvens/blob/master/index.js#L181-L205
The text was updated successfully, but these errors were encountered: