Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve unaddressed nits in #703 #707

Merged
merged 7 commits into from
Jul 6, 2024
Merged

Resolve unaddressed nits in #703 #707

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7ccb01b
added tests leftout tests ticketing
Porcupine1 Jun 3, 2024
3f0ec11
address nits
Porcupine1 Jun 20, 2024
1234e41
remove TODO
Porcupine1 Jun 20, 2024
7015328
add transaction record test
Porcupine1 Jun 20, 2024
c52fb53
address more nits
Porcupine1 Jun 21, 2024
39a9b7d
keep TODO
Porcupine1 Jun 21, 2024
549c712
address last nit
Porcupine1 Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address more nits
  • Loading branch information
@Porcupine1
Porcupine1 committed Jun 21, 2024
commit c52fb5359fa7fc0792c604cd00be18e467f15e16
6 changes: 3 additions & 3 deletions backend/tests/clubs/test_ticketing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ def test_give_tickets(self):
# Check that the cart is empty
self.assertEqual(0, cart.tickets.count())

# Transaction record created
# Check that transaction record is created
record_exists = TicketTransactionRecord.objects.filter(
reconciliation_id=MockPaymentResponse().reconciliation_id
).exists()
Expand Down Expand Up @@ -1160,7 +1160,7 @@ def test_initiate_checkout_only_free_tickets(self):
held_tickets = Ticket.objects.filter(holder=self.user1)
self.assertEqual(held_tickets.count(), 0, held_tickets)

# Transaction record created
# Check that transaction record is created
record_exists = TicketTransactionRecord.objects.filter(
reconciliation_id="None"
).exists()
Expand Down Expand Up @@ -1339,7 +1339,7 @@ def test_complete_checkout(self):
held_tickets = Ticket.objects.filter(holder=self.user1)
self.assertEqual(held_tickets.count(), 0, held_tickets)

# Transaction record created
# Check that transaction record is created
record_exists = TicketTransactionRecord.objects.filter(
reconciliation_id=MockPaymentResponse().reconciliation_id
).exists()
Expand Down
Loading