Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve unaddressed nits in #703 #707

Merged
merged 7 commits into from
Jul 6, 2024
Merged

Resolve unaddressed nits in #703 #707

merged 7 commits into from
Jul 6, 2024

Conversation

Porcupine1
Copy link
Contributor

-Remove TODO
-Test that transaction record create when _give_tickets() is called

@Porcupine1 Porcupine1 changed the title Place hold give tickets tests (Resolve unaddressed nits) Resolve unaddressed nits in #703 Jun 20, 2024
@Porcupine1 Porcupine1 self-assigned this Jun 20, 2024
@Porcupine1 Porcupine1 linked an issue Jun 20, 2024 that may be closed by this pull request
Add tests left out in #658 #702
Closed
aviupadhyayula
aviupadhyayula reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@aviupadhyayula aviupadhyayula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for circling back to these. In the future, just make a new PR/commit to address comments given after a PR's already been merged.

backend/clubs/models.py Outdated Show resolved Hide resolved
backend/tests/clubs/test_ticketing.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.11%. Comparing base (8561edc) to head (549c712).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   71.10%   71.11%           
=======================================
  Files          31       31           
  Lines        6824     6826    +2     
=======================================
+ Hits         4852     4854    +2     
  Misses       1972     1972

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Porcupine1 Porcupine1 merged commit a3d27de into master Jul 6, 2024
9 checks passed
@Porcupine1 Porcupine1 deleted the place_hold_give_tickets_tests branch July 6, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviupadhyayula aviupadhyayula aviupadhyayula left review comments

Assignees

@Porcupine1 Porcupine1

Labels
backend
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests left out in #658
2 participants
@Porcupine1 @aviupadhyayula