Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entries get duplicated and/or code is wrong when view is sorted #184

Closed
paolostivanin opened this issue Jul 23, 2020 · 10 comments
Closed

Entries get duplicated and/or code is wrong when view is sorted #184

paolostivanin opened this issue Jul 23, 2020 · 10 comments
Assignees
Milestone

Comments

@paolostivanin
Copy link
Owner

When column is sorted, some entries get duplicated.
This seems to be an issue with GtkTreeView itself, so I need to add some kind of workaround.

For now, resetting the sorting order fixes the issue.

@paolostivanin
Copy link
Owner Author

@paolostivanin
Copy link
Owner Author

@paolostivanin paolostivanin pinned this issue Jan 25, 2021
@paolostivanin paolostivanin changed the title Entries get duplicated when view is sorted Entries get duplicated and/or code is wrong when view is sorted Jan 25, 2021
@FranciscoPombal
Copy link
Contributor

Can confirm. This is the most serious and annoying bug right now IMO. Other than that, this is a great piece of software.

@paolostivanin
Copy link
Owner Author

I agree, that's super annoying. And, unfortunately, the only thing I can do is to migrate away from GtkTreeView...

@FranciscoPombal
Copy link
Contributor

I guess this is the related upstream bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/2892.

Unfortunately, it is closed now. But judging from the only response it received, it seems like they missed the point a bit. I think it would be worth re-submitting or reopening, perhaps with a GIF showing it happening on OTPClient.

Also, I should clarify that in my case, I don't think I've ever experienced the "duplication" - just the wrong 2FA code being displayed in the wrong row.

@paolostivanin
Copy link
Owner Author

If you execute gtk3-demo, go to Tree View, then List Sore, hit run and reorder the spinning column, you'll see some weird behavior there.
There's actually no point in opening another bug report, because the GNOME team wants to eventually deprecate treeview. So better to migrate away from it asap :)

@forerser
Copy link

forerser commented Sep 6, 2021

When column is sorted, some entries get duplicated.
This seems to be an issue with GtkTreeView itself, so I need to add some kind of workaround.

For now, resetting the sorting order fixes the issue.

how to reset sorting order??

Today no one code works, but yesterday everything worked fine. I use 2.4.4 version

@paolostivanin
Copy link
Owner Author

That's weird, sorting has been disabled on 2.4.4, so this shouldn't be an issue anymore.
Have you checked if your system clock is in sync with the real time?

@forerser
Copy link

the error was exactly the system clock.

@paolostivanin paolostivanin removed this from In Progress in Release 3.0.0 Nov 30, 2021
@paolostivanin paolostivanin modified the milestones: 3.0.0, 2.5.0 Nov 30, 2021
@paolostivanin paolostivanin added this to In progress in Release 2.5.0 Dec 16, 2021
@paolostivanin paolostivanin moved this from In progress to To do in Release 2.5.0 Feb 19, 2022
@paolostivanin paolostivanin moved this from To do to In progress in Release 2.5.0 Feb 19, 2022
@paolostivanin
Copy link
Owner Author

paolostivanin commented Mar 24, 2022

  • implement rows drag and drop
    • add button to toggle reorder feature
    • set treeview reordable
    • update the database with the new order
  • test code
    • reorder and exit app
    • remove an otp and check that it still works fine
    • shows one or more otp, reorder the rows, exit the app

@paolostivanin paolostivanin moved this from In progress to Done in Release 2.5.0 Mar 30, 2022
paolostivanin added a commit that referenced this issue Mar 30, 2022
this finally fixes #184
paolostivanin added a commit that referenced this issue Mar 30, 2022
this finally fixes #184
@paolostivanin paolostivanin unpinned this issue Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants