Editing account and issuer of one row causes changes to another row

[Leonov65]

I experienced strange behaviour from OTPClient when editing the email address in a saved account. My aim in doing this was to alter the account's entry so that its email address would not be displayed in full. I wanted to create my own simplified account name entry that did not have the format of an email address - no @ symbol, no .tld, just an abbreviated short letter code that I would recognise. Each of my TOTP accounts has a unique email address.

After the email address was altered neighbouring rows were overwritten with the edited row's account name and issuer name. The rows displayed identical account and issuer information, but each still produced unique TOTP codes. To correct the problem I used displayed TOTP codes to check against an authenticator app on my phone to identify the true account a row belonged to. Then I could try to reverse my edits.

Attempts to reverse the edits to revert to the original state in OTPClient did not correct the problem. Instead it propagated it to the next row down. I soon had three rows with identical information and each displaying unique TOTP soft-tokens. In frustration I deleted the rows with erroneous account and issuer information, and then recreated them from QR code screenshots recorded from provider websites at the time of TOTP account creation. That returned things to normal.

I have altered account and issuer info in Android phone TOTP authenticator apps without problem. Not sure why doing so causes hiccups with OTPClient.

OTPClient 2.4.2 via Flatpak on Ubuntu 20.04

[paolostivanin]

🤔 very weird, indeed.
Did you by chance sorted the columns? (e.g. clicked on the column header?)

[Leonov65]

The issue is separate to column sorting. That works as expected.

I may not have recalled all details needed to reproduce the weirdness. I may have also edited account field. That aside, I am sure my edited information propagated from one row to another. I saw the same behaviour after edits on two separate occasions.

By the way, I really appreciate the feature that permits QR codes to be entered from image files. I record screenshots of QR codes created by service providers as backup. Makes it quick and easy to get going again with TOTP soft-tokens. Used these image files with OTPClient to reinstate deleted rows.

[paolostivanin]

Glad you like that feature :) I was thinking whether or not to drop it for v3, but as it seems to be useful to someone I'll keep it 👍

BTW, I'll investigate and let you know if I have any more questions!

[paolostivanin]

I was able to reproduce the bug when columns were sorted.
With sorting disabled, all was good.

As multiple users are being affected every day, I'll push a 2.4.4 release that will completely disabled sorting. TreeView is broken and this will taken care of with 3.0.0,

Closing this as duplicate of #184