Ledger test suite #1640
Open
Ledger test suite #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command (supported only on debug builds) lets the wallet force reset the Ledger device onto the given network type for testing purposes.
This *substantially* increases the Ledger wallet startup time for testing.
This was returning the base task exception, but that is often a timeout because of the interaction failure, so show the interaction failure instead.
On mainnet, you can disable (by design) use of the shared-ringdb by using `--shared-ringdb-dir` with an empty argument, but the code handling the argument on testnet/devnet/fakenet appended `testnet`/`devnet`/`fake` to the path, which made it non-empty and thus failed to disable it as intended. This fixes it.
The shared-ringdb appears to be buggy (in that it sometimes fails to return outputs it should know about) when interacting with a very short chain, as we have for all of the fakechain ledger tests, so just disable it to avoid hitting those bugs.
We need a new, fresh network every time because there often aren't enough funds otherwise to conduct tests (plus it makes tests difficult to repeat since the selection and order of tests can change things).
`balance(x)` is a shortcut for `coins(x, x)`, which is particularly useful in a bunch of places where `x` is a complex expression and so currently we're doing messy things like `(coins(xxxxxxxxxxxx),) * 2`. StoreFee() is a helper class for storing a fee, replacing the `store_fee()` function that was heavily duplicated in the test code.
- Fix NanoX multi-value reader to read all the lines instead of just line 2. - Add a bunch of hacky workarounds for the broken NanoX speculos support (it omits any "S"s on the screen). - Add a README describing how to run it all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a high-level test suite for the Ledger wallet, along with a few small changes for the
stablebranch needed to make the test suite code work.