-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #140: Topic play animation #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM animation works fine. To keep one item expanded and others collapse may be this can help here
Thanks, this reference uses notifyDataSetAdapterChanged(), which is the main issue, but I will try to get some help. |
@veena14cs this link did help. Updated the code to improvise on animation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please get approval from @mschanteltc for the animation.
The animation LGTM. |
@nikitamarysolomanpvt assigning this to you, as discussed earlier the animation is not working, so you can investigate this. |
@rt4914 ya as we discussed the animation is not helping is slidingup and down a few other animations library i used where not supporting properly animation in the list. So assigning back to you mean while i will try a few more during my free-time. |
@nikitamarysolomanpvt As per my conversation with @BenHenning we should not de-prioritise this. Instead @BenHenning has suggested some other points. First, as the mocks have updated we can again try for some different animation. If that does not work, then in that case, we should come up with our own animation which is technically easy as well as pleasant and resonates with the overall application. In that case, we can suggest Chantel about those animations and after discussion we can update the animations in mocks too. |
Okay let me know if you are working on this and i will let you know, if before that if i am able to come up with a suitable solution. |
Closing this PR, as the primary code base has been changed a lot. But issue will still remain open and we will fixing this going forward. |
Explanation
This PR introduces animation in Topic Play.
But after this animation, there is one loss of functionality, the items which have been opened earlier will remain open and won't close if other items expand.
Checklist