Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #140: Topic play animation #486

Closed
wants to merge 11 commits into from

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 28, 2019

Explanation

This PR introduces animation in Topic Play.

But after this animation, there is one loss of functionality, the items which have been opened earlier will remain open and won't close if other items expand.

topic_play_animation_2

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM animation works fine. To keep one item expanded and others collapse may be this can help here

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Nov 29, 2019
@rt4914
Copy link
Contributor Author

rt4914 commented Nov 29, 2019

LGTM animation works fine. To keep one item expanded and others collapse may be this can help here

Thanks, this reference uses notifyDataSetAdapterChanged(), which is the main issue, but I will try to get some help.

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 29, 2019

LGTM animation works fine. To keep one item expanded and others collapse may be this can help here

@veena14cs this link did help. Updated the code to improvise on animation.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Nov 29, 2019
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please get approval from @mschanteltc for the animation.

@mschanteltc
Copy link

LGTM. Please get approval from @mschanteltc for the animation.

The animation LGTM.

@mschanteltc mschanteltc removed their assignment Nov 30, 2019
@rt4914
Copy link
Contributor Author

rt4914 commented Dec 16, 2019

@nikitamarysolomanpvt assigning this to you, as discussed earlier the animation is not working, so you can investigate this.

@nikitamarysolomanpvt
Copy link
Contributor

@nikitamarysolomanpvt assigning this to you, as discussed earlier the animation is not working, so you can investigate this.

@rt4914 ya as we discussed the animation is not helping is slidingup and down a few other animations library i used where not supporting properly animation in the list. So assigning back to you mean while i will try a few more during my free-time.

@rt4914
Copy link
Contributor Author

rt4914 commented Dec 19, 2019

@nikitamarysolomanpvt assigning this to you, as discussed earlier the animation is not working, so you can investigate this.

@rt4914 ya as we discussed the animation is not helping is slidingup and down a few other animations library i used where not supporting properly animation in the list. So assigning back to you mean while i will try a few more during my free-time.

@nikitamarysolomanpvt As per my conversation with @BenHenning we should not de-prioritise this. Instead @BenHenning has suggested some other points. First, as the mocks have updated we can again try for some different animation. If that does not work, then in that case, we should come up with our own animation which is technically easy as well as pleasant and resonates with the overall application. In that case, we can suggest Chantel about those animations and after discussion we can update the animations in mocks too.

@nikitamarysolomanpvt
Copy link
Contributor

@nikitamarysolomanpvt assigning this to you, as discussed earlier the animation is not working, so you can investigate this.

@rt4914 ya as we discussed the animation is not helping is slidingup and down a few other animations library i used where not supporting properly animation in the list. So assigning back to you mean while i will try a few more during my free-time.

@nikitamarysolomanpvt As per my conversation with @BenHenning we should not de-prioritise this. Instead @BenHenning has suggested some other points. First, as the mocks have updated we can again try for some different animation. If that does not work, then in that case, we should come up with our own animation which is technically easy as well as pleasant and resonates with the overall application. In that case, we can suggest Chantel about those animations and after discussion we can update the animations in mocks too.

Okay let me know if you are working on this and i will let you know, if before that if i am able to come up with a suitable solution.

@rt4914 rt4914 mentioned this pull request Dec 19, 2019
8 tasks
@rt4914
Copy link
Contributor Author

rt4914 commented Jan 30, 2020

Closing this PR, as the primary code base has been changed a lot. But issue will still remain open and we will fixing this going forward.

@rt4914 rt4914 closed this Jan 30, 2020
@rt4914 rt4914 deleted the topic-play-animation-part-1 branch January 30, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants