Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final UI: Topic play tab fragment [Blocked: #15, #137] #140

Closed
7 tasks
BenHenning opened this issue Sep 19, 2019 · 4 comments
Closed
7 tasks

Final UI: Topic play tab fragment [Blocked: #15, #137] #140

BenHenning opened this issue Sep 19, 2019 · 4 comments
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
Ship Oppia on Android Prototype Oppia on Android
Milestone
0.4 Release Block...

Comments

@BenHenning
Copy link
Sponsor Member

BenHenning commented Sep 19, 2019 •
edited by rt4914
Loading

This is tracking implementing the high fidelity UI for the topic play tab.

Mock Link: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/94a5f38c-e475-4514-8784-0e42cf70c25e/TP-Play-Scrolled-Up-

Task Checklist

  • Stories You Can Play text, along with line separators in between story-items (Assigned to @rt4914 )

Screenshot 2019-11-07 at 4 00 43 PM

  • Story Progress UI in following 3 cases, 100% progress story (Fully Finished), 0% progress story (Not yet started) and 33% progress story (partial completion) (or some double digit based percentage) (Assigned to @rt4914 )

Screenshot 2019-11-07 at 4 00 51 PM

Screenshot 2019-11-07 at 4 00 58 PM

  • Story Summary Item including chapter count is correctly aligned and dropdown is functional with appropriate animations (if needed). (Assigned to @rt4914 )

Screenshot 2019-11-07 at 4 01 16 PM

  • Chapter Summary Item including tick if the chapter is completed and correct chapter color. Chapter color is based on following points:
  • If Chapter is finished: BLACK (What is a Fraction? in mocks)
  • If Chapter is in Progress: BLACK (The Meaning of "Equal Parts" in mocks)
  • If Chapter is not yet started: GREY (Fractions of a Group in mocks) (Assigned to @rt4914 )

Screenshot 2019-11-07 at 4 01 27 PM

  • Full story item along with drop down animation (Assigned to @rt4914 )

Screenshot 2019-11-07 at 4 05 02 PM
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 19, 2019
@BenHenning BenHenning added this to Triage in Ship Oppia on Android via automation Sep 19, 2019
@BenHenning BenHenning added this to Triage in Prototype Oppia on Android via automation Sep 19, 2019
@BenHenning
Copy link
Sponsor Member Author

This is blocked on #137 for structure and #15 for full domain functionality.

@BenHenning BenHenning moved this from Triage to Blocked in Prototype Oppia on Android Sep 20, 2019
@rt4914 rt4914 assigned rt4914 and unassigned rt4914 Oct 29, 2019
@rt4914 rt4914 mentioned this issue Nov 11, 2019
Merged
8 tasks
rt4914 added a commit that referenced this issue Nov 12, 2019
@rt4914
Fix part of #140: Lowfi-TopicPlayTab-CustomProgressView (#329)
041c296 
* CustomProgressView

* Dynamic story progress

* Finishing touch 1

* Nit changes

* Stuck on one issue

* Final nit changes

* File name changed
rt4914 added a commit that referenced this issue Nov 14, 2019
@rt4914
Fix part of #140: Hifi topic play (#339)
e13b784 
* Title and recyclerview fix

* Inital UI implementation

* Icons checks

* Nit changes

* Fix chapter min height

* Final accessibility scanner test

* Nit suggested changes

* Nit change

* Updated click listeners

* Final changes

* Changes on ChapterView
@BenHenning
Copy link
Sponsor Member Author

@rt4914 can you clarify what remaining work needs to be done here?

@BenHenning BenHenning mentioned this issue Nov 30, 2019
Closed
29 tasks
@rt4914 rt4914 mentioned this issue Dec 2, 2019
Closed
4 tasks
@rt4914
Copy link
Contributor

rt4914 commented Dec 2, 2019

WIP in #486

@rt4914
Copy link
Contributor

rt4914 commented Aug 6, 2020

This was finished with the last PR being #1465 (animation PR.)

@rt4914 rt4914 closed this as completed Aug 6, 2020
Ship Oppia on Android automation moved this from Triage to Done Aug 6, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Prototype Oppia on Android
  
Blocked
Ship Oppia on Android
  
Done
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
2 participants
@rt4914 @BenHenning