Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1587: Made intent/bundle/saved/tags instance keys consistent. #3880

Merged
merged 10 commits into from
Oct 7, 2021
Merged

Fix #1587: Made intent/bundle/saved/tags instance keys consistent. #3880

merged 10 commits into from
Oct 7, 2021

Conversation

ayush0402
Copy link
Contributor

Explanation

Fixes #1587

Extending from PR #3869 (some issue with branches on my local machine)

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@ayush0402
Copy link
Contributor Author

@rt4914 @anandwana001 Is it correct? PTAL.

@ayush0402 ayush0402 mentioned this pull request Oct 6, 2021
Closed
6 tasks
rt4914
rt4914 approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 removed their assignment Oct 6, 2021
anandwana001
anandwana001 approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owners files LGTM

@anandwana001 anandwana001 merged commit 8eabe16 into oppia:develop Oct 7, 2021
@ayush0402 ayush0402 deleted the consistent_KEYS3 branch October 7, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make intent/bundle/saved/tags instance keys consistent.
3 participants
@ayush0402 @rt4914 @anandwana001