Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make intent/bundle/saved/tags instance keys consistent. #1587

Closed
rt4914 opened this issue Aug 10, 2020 · 13 comments · Fixed by #3880
Closed

Make intent/bundle/saved/tags instance keys consistent. #1587

rt4914 opened this issue Aug 10, 2020 · 13 comments · Fixed by #3880
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Aug 10, 2020

The keys should be consistent in intents, bundles, tags, etc. They should mainly follow below mentioned structure.

For fragments:
<PROPERTY_NAME>_ARGUMENT_KEY = "<FileName>.<property_name>"
Example: INTERNAL_PROFILE_ID_ARGUMENT_KEY = "SampleFragment.internal_profile_id"

For activities:
<PROPERTY_NAME>_EXTRA_KEY = "<FileName>.<property_name>"
Example: INTERNAL_PROFILE_ID_EXTRA_KEY = "SampleActivity.internal_profile_id"

For saved instances:
<PROPERTY_NAME>_SAVED_KEY = "<FileName>.<property_name>"
Example: INTERNAL_PROFILE_ID_SAVED_KEY = "SampleActivity.internal_profile_id"
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Status: Not started labels Aug 10, 2020
@The-Pascal
Copy link

@rt4914 I would like to work on this issue.

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 25, 2020

@rt4914 I would like to work on this issue.

@rt4914 I want to work on this issue.

Hello @The-Pascal
Thanks for showing interest. Before we assign you issue to work on please sign the CLA and fill the survey form mentioned here https://github.com/oppia/oppia-android/wiki

Once done, we can assign you issues to work on.

@The-Pascal The-Pascal mentioned this issue Aug 26, 2020
Closed
The-Pascal added a commit to The-Pascal/oppia-android that referenced this issue Aug 26, 2020
@The-Pascal
Fix oppia#1587 : Made intent/bundle/saved/tags instance keys consistent
7206d49
@The-Pascal The-Pascal mentioned this issue Aug 26, 2020
Closed
8 tasks
The-Pascal added a commit to The-Pascal/oppia-android that referenced this issue Aug 27, 2020
@The-Pascal
Fix oppia#1587 : Resolve test cases error. Made intent keys consistent.
ad6738d
The-Pascal added a commit to The-Pascal/oppia-android that referenced this issue Aug 27, 2020
@The-Pascal
Fix oppia#1587 : Resolve test cases error. Made intent keys consistent.
e488310
The-Pascal added a commit to The-Pascal/oppia-android that referenced this issue Aug 27, 2020
@The-Pascal
Fix oppia#1587 : Tags related to fragment / activities made consistent.
0864cae
The-Pascal added a commit to The-Pascal/oppia-android that referenced this issue Sep 2, 2020
@The-Pascal
Fix oppia#1587 : Renamed and added TAGS in companion object.
866c292
The-Pascal added a commit to The-Pascal/oppia-android that referenced this issue Sep 2, 2020
@The-Pascal
Fix oppia#1587 : Renamed and added TAGS in companion object.
4e561f5
The-Pascal added a commit to The-Pascal/oppia-android that referenced this issue Sep 2, 2020
@The-Pascal
Fix oppia#1587 : Renamed and added TAGS in companion object.
b3969d7
The-Pascal added a commit to The-Pascal/oppia-android that referenced this issue Sep 2, 2020
@The-Pascal
Fix oppia#1587 : Renamed and added TAGS in companion object.
08be64d
@BenHenning BenHenning added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 1, 2020
@janewaitara
Copy link
Contributor

@rt4914 I would like to work on this issue

@rt4914
Copy link
Contributor Author

rt4914 commented Oct 21, 2020

@rt4914 I would like to work on this issue

@janewaitara Assigned. Thanks.

This was referenced Oct 29, 2020
Closed
Closed
Merged
Merged
@janewaitara
Copy link
Contributor

janewaitara commented Nov 13, 2020 •
edited
Loading

SAVED INSTANCE KEYS - Fixed in #2064

  • HintsAndSolutionDialogFragment
  • AppLanguageFragment
  • AudioLanguageFragment
  • OptionsActivity
  • TopicLessonsFragment
  • AdministratorControlsActivity

INTENT KEYS

Options and Player Packages - Fixed in #2066

  • OptionsFragment
  • StateFragmentTestActivity
  • OptionsActivity
  • AppLanguageActivity

Profile and Settings.profile packages - Fixed in #2106

Profile package

  • AddProfileActivity
  • AdminAuthActivity
  • AdminPinActivity
  • PinPasswordActivity

Settings Profile

  • ProfileEditActivity
  • ProfileRenameActivity
  • ProfileResetPinActivity

Drawer, Testing and Topic packages - Fixing in progress

Drawer package

  • NavigationDrawerFragmentPresenter

Testing

  • AudioFragmentTestActivity

Topic

  • TopicActivity
  • QuestionPlayerActivity

@janewaitara janewaitara mentioned this issue Nov 13, 2020
Merged
8 tasks
@janewaitara janewaitara mentioned this issue Nov 25, 2020
Closed
8 tasks
rt4914 pushed a commit that referenced this issue Nov 25, 2020
@janewaitara
Fix part of #1587: Made intent keys consistent in the options and pla…
ebf58a8 
…yer packages in the app module (#2066)

* Made intent keys consistent in the options and player packages in the app module

* Klint style issues fixed
@BenHenning BenHenning removed the Hacktoberfest This is a suggested Hacktoberfest issue. label Dec 3, 2020
@rt4914 rt4914 mentioned this issue Jan 12, 2021
Closed
15 tasks
@yurilev
Copy link
Contributor

yurilev commented Jan 30, 2021

Can I work on the remaining files?

@janewaitara
Copy link
Contributor

Can I work on the remaining files?

@yurilev I'm currently working on the files

@janewaitara janewaitara mentioned this issue Jan 30, 2021
Closed
8 tasks
@yurilev
Copy link
Contributor

yurilev commented Jan 31, 2021

I'm sorry, I asked because no one was currently assigned.

@ayush0402
Copy link
Contributor

I would like to work on this issue.

@prayutsu
Copy link
Contributor

Assigning this to you @ayush0402 :)

@ayush0402 ayush0402 mentioned this issue Jun 22, 2021
Merged
8 tasks
@rt4914 rt4914 mentioned this issue Jun 26, 2021
Merged
8 tasks
anandwana001 pushed a commit that referenced this issue Jun 28, 2021
@ayush0402
Fix part of #1587: Made some intent/bundle/saved/tags instance keys c…
be570f4 
…onsistent. (#3350)

* renamed some keys consistent

* renamed some more keys consistent

* consistent-keys fixed PR issues

* consistent-keys added EOF
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 12, 2021
@rt4914 rt4914 moved this from Needs Triage to Backlog in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@anandwana001
Copy link
Contributor

@ayush0402 any update on this?

@ayush0402
Copy link
Contributor

@anandwana001 I am working on other issue right now.

@anandwana001
Copy link
Contributor

Thanks for the update, unassigned you for now. Let me when start working on this again, I will assign you back.

@ayush0402 ayush0402 self-assigned this Oct 1, 2021
This was referenced Oct 1, 2021
Closed
Merged
CLAM Team (deprecated -- please use new board) automation moved this from Backlog (things to organize into workstreams) to Closed Oct 7, 2021
anandwana001 pushed a commit that referenced this issue Oct 7, 2021
@ayush0402
Fix #1587: Made intent/bundle/saved/tags instance keys consistent. (#…
8eabe16 
…3880)

* renaming keys

* linting fix

* fixed more files

* linting fix

* fixing errors

* requested changes

* commit

* linting fix

* reverted a change
@ayush0402 ayush0402 removed their assignment Oct 7, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone
8 participants
@yurilev @rt4914 @BenHenning @anandwana001 @janewaitara @prayutsu @The-Pascal @ayush0402