Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #3474: Merged faq single activity into one layout file and updated dimens.xml (land),(sw600dp-land) #3518

Closed
wants to merge 5 commits into from
Closed

Fix part of #3474: Merged faq single activity into one layout file and updated dimens.xml (land),(sw600dp-land) #3518

wants to merge 5 commits into from

Conversation

rishidyno
Copy link
Contributor

@rishidyno rishidyno commented Jul 24, 2021 •
edited
Loading

Fix #3474

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rishidyno
Copy link
Contributor Author

rishidyno commented Jul 24, 2021 •
edited
Loading

Fix #3474

I have merged the faq_single_activity.xml file into a single file. I have deleted unnecessary values in dimens.xml.

Screenshots before merging into a single file.

mobile-portrait
mobile-landscape
tablet-portrait
tablet-landscape

Screenshots after merging into a single file.
mobile-portrait
mobile-landscape
tablet-landscape
tablet-portrait

Earlier it crashed when in the tablet landscape mode but not the dimension does not match as before because of
android:layout_width="match_parent"
which was 560dp in the original version of the landscape

@rishidyno rishidyno mentioned this pull request Jul 24, 2021
Closed
prayutsu
prayutsu suggested changes Jul 24, 2021
View reviewed changes
Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishidyno Please follow the PR checklist and link the related issue with the PR.
Also please revert the unwanted changes.

.idea/misc.xml Outdated
<output url="file:https://$PROJECT_DIR$/build/classes" />
</component>
<component name="ProjectType">
<option name="id" value="Android" />
</component>
</project>
</project>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are unwanted, revert them.

.idea/runConfigurations.xml Outdated
@@ -3,10 +3,11 @@
<component name="RunConfigurationProducerService">
<option name="ignoredProducers">
<set>
<option value="com.android.tools.idea.compose.preview.runconfiguration.ComposePreviewRunConfigurationProducer" />
<option value="org.jetbrains.plugins.gradle.execution.test.runner.AllInPackageGradleConfigurationProducer" />
<option value="org.jetbrains.plugins.gradle.execution.test.runner.TestClassGradleConfigurationProducer" />
<option value="org.jetbrains.plugins.gradle.execution.test.runner.TestMethodGradleConfigurationProducer" />
</set>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@rishidyno rishidyno changed the title Fix #3474: Merged faq single activity into one layout file and updated dimens.xml (land),(sw600dp-land) Fix part of #3474: Merged faq single activity into one layout file and updated dimens.xml (land),(sw600dp-land) Jul 24, 2021
@rishidyno
Copy link
Contributor Author

@prayutsu I have done some changes to the code but am still not able to resolve the issue but working on it.

@rishidyno
Copy link
Contributor Author

rishidyno commented Jul 26, 2021 •
edited
Loading

This PR had some issues so I have closed it and I have created a new PR -> #3526

@rishidyno rishidyno closed this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prayutsu prayutsu prayutsu requested changes

@BenHenning BenHenning Awaiting requested review from BenHenning

@rt4914 rt4914 Awaiting requested review from rt4914

Assignees

@rishidyno rishidyno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert faq_single_activity into single layout file
2 participants
@rishidyno @prayutsu