Convert faq_single_activity into single layout file #3474
Assignees
Labels
good first issue
This item is good for new contributors to make their pull request.
Priority: Nice-to-have
This work item is nice to have for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
anandwana001
added
good first issue
rt4914
added this to Needs Triage
in CLAM Team (deprecated -- please use new board)
via automation
rt4914
moved this from Needs Triage
to Backlog (things to organize into workstreams)
in CLAM Team (deprecated -- please use new board)
|
Sir, i would like to work on this issue. |
|
Hi @rishidyno |
|
@anandwana001 I have added a pull request for the same with some details. |
This was referenced Jul 25, 2021
8 tasks
CLAM Team (deprecated -- please use new board)
automation
moved this from Backlog (things to organize into workstreams)
to Closed
Aug 6, 2021
rt4914
pushed a commit
that referenced
this issue
Aug 6, 2021
* in progress * in progress * in progress * in progress * merged faq_single_activity.xml into one file * merged faq_single_activity.xml into one file * merged faq_single_activity.xml into one file * added EOL * Added EOL to booleans.xml sw600-dp * deleted 3 versions of topic_practice_footer_view.xml and merged it into one updated * updated project * updating project * updating project * Renamed to faq_single_activity_scroll_padding_Bottom to faq_single_activity_scroll_padding_bottom * Renamed to faq_single_activity_scroll_padding_Bottom to faq_single_activity_scroll_padding_bottom * Renamed to faq_single_activity_scroll_padding_Bottom to faq_single_activity_scroll_padding_bottom * Renamed to faq_single_activity_scroll_padding_Bottom to faq_single_activity_scroll_padding_bottom * Delete deploymentTargetDropDown.xml * deleted boolenas.xml sw600dp-land Now we are having 2 versions of faq_single_activity we don't need to mention fillViewport attribute so i have deleted this file * deleted unnecessary fillviewPort attribute from activity * Deleted 2 unnecessary attributes in default layout * Delete deploymentTargetDropDown.xml
BenHenning
added
the
Z-ibt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently there are 3 versions of
faq_single_activity .xmlfile merge it into single xml file.We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in the
dimens.xmlfile and use it accordingly.Note: In PR, make sure you add before and after screenshots of
mobile-portrait,mobile-landscape,tablet-portrait, andtablet-landscapefor comparison and make sure that there is no difference between before and after UI.The text was updated successfully, but these errors were encountered: