Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2628: Reading Text Size[A11y] #2929

Merged
merged 32 commits into from
Jun 9, 2021
Merged

Fixes #2628: Reading Text Size[A11y] #2929

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
efacdc5
Fixes #2628: Reading Text Size[A11y]
Arjupta Mar 16, 2021
3efcd0a
EOF fix
Arjupta Mar 16, 2021
aa8214f
Lint Checks
Arjupta Mar 16, 2021
aa3256b
Corrected the Talkback Output
Arjupta Mar 20, 2021
3c80f1a
Included TextSizeItemViewModel in BUILD.bazel
Arjupta Apr 16, 2021
fbd5856
Included ReadingTextSizeSelectionViewModel in BUILD.bazel
Arjupta Apr 16, 2021
0d60305
Included TextSizeRadioButtonListener in BUILD.bazel
Arjupta Apr 16, 2021
0f56bcb
Changes for RedingTextSizeSelectionViewModel which has resource imports
Arjupta Apr 16, 2021
0998b22
Fixing the tests for New TextSizeSelection UI
Arjupta Apr 18, 2021
c59cc86
Fixing Lint Issues
Arjupta Apr 18, 2021
41d207a
Fixed the TextSize ViewMatcher
Arjupta Apr 18, 2021
7590b06
Added KDocs and refactored function names
Arjupta Apr 19, 2021
6191f10
Apply suggestions from code review
Arjupta Apr 19, 2021
2269150
Corrections due to applied suggestions from Code Review
Arjupta Apr 19, 2021
533627b
Reverting one suggestion of not using lazy initialization
Arjupta Apr 20, 2021
fc9ab60
Nit changes
Arjupta Apr 21, 2021
994968d
Fixes Bug of not updating reading text size correctly
Arjupta Apr 24, 2021
29cdfea
Changed the location of ReadingTextSizeFragmentTest
Arjupta May 2, 2021
0272c9d
add the file
Arjupta May 3, 2021
f556a91
Merge branch 'develop' into reading-text-size
Arjupta May 3, 2021
c93ccb3
Suggested changes
Arjupta May 4, 2021
1153a13
Updating with develop
Arjupta May 10, 2021
2ab5b12
Sugggested changes by @rt4914
Arjupta May 11, 2021
a5bf18c
Failing check due to unwanted import
Arjupta May 12, 2021
f29c4e6
added kdoc for ReadingTextSizeFragment
Arjupta May 12, 2021
b8b8c2d
Added padding dimension for landscape layout and removed val from inj…
Arjupta May 12, 2021
63b844c
Suggested update
Arjupta May 20, 2021
bb9dee6
Merge remote-tracking branch 'origin' into reading-text-size
Arjupta May 21, 2021
5915f76
Merge branch 'reading-text-size' of https://github.com/ARJUPTA/oppia-…
Arjupta May 21, 2021
9aca655
Adding qualifier as suggested
Arjupta May 22, 2021
ae9e456
Adding suggested comments
Arjupta Jun 2, 2021
9a691d4
Corrected the comment format
Arjupta Jun 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding suggested comments
  • Loading branch information
@Arjupta
Arjupta committed Jun 2, 2021
commit ae9e456301f815171b6e65e571052063658c879a
2 changes: 2 additions & 0 deletions app/src/sharedTest/java/org/oppia/android/app/options/ReadingTextSizeFragmentTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ import org.robolectric.annotation.LooperMode
import javax.inject.Inject
import javax.inject.Singleton

/* 1.These duplicates are intentional to make sure that that the production values are not changed by mistake. */
/* 2.TODO #1815: Remove these duplicate values once Screenshot tests are implemented. */
private const val SMALL_TEXT_SIZE_SCALE = 0.8f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add following comments:

  1. These duplicates are intentional to make sure that that the production values are not changed by mistake.
  2. TODO Intoduce screenshot-testing framework #1815: Remove these duplicate values once Screenshot tests are implemented.

@Arjupta PTAL

Copy link
Contributor Author

@Arjupta Arjupta Jun 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 LGTM. Adding them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO format is correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format can be confirmed from code. I just mentioned it as points.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arjupta Format these comments correctly.

// These duplicates are intentional to make sure that that the production values are not changed 
// by mistake.
// TODO(#59): 1815: Remove these duplicate values once Screenshot tests are implemented.

The above comment was for understanding not in comments format.

private const val MEDIUM_TEXT_SIZE_SCALE = 1.0f
private const val LARGE_TEXT_SIZE_SCALE = 1.2f
Expand Down