Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2628: Reading Text Size[A11y] #2929

Merged
merged 32 commits into from
Jun 9, 2021
Merged

Fixes #2628: Reading Text Size[A11y] #2929

merged 32 commits into from
Jun 9, 2021

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Mar 16, 2021 •
edited
Loading

Explanation

Fixes #2628 based on the mock provided here

New Layout Accessibility Scan
111349733-68275280-86a7-11eb-959f-accf17d8ef4f Screenshot_1616252207

Tests passing-

Untitled

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Arjupta Arjupta requested a review from rt4914 as a code owner March 16, 2021 17:02
@Arjupta
Copy link
Contributor Author

Arjupta commented Mar 16, 2021

@rt4914 and @mschanteltc we need to have content description for the radio buttons also as they give this output with the TalkBack
WhatsApp Image 2021-03-16 at 10 26 31 PM (1) WhatsApp Image 2021-03-16 at 10 26 31 PM (2) WhatsApp Image 2021-03-16 at 10 26 31 PM WhatsApp Image 2021-03-16 at 10 26 31 PM (5)

@rt4914
Copy link
Contributor

rt4914 commented Mar 17, 2021

@Arjupta Can you try the solution done in #2784 ?

@rt4914 rt4914 assigned Arjupta and unassigned rt4914 Mar 17, 2021
@anandwana001
Copy link
Contributor

@Arjupta any update on this?

@Arjupta
Copy link
Contributor Author

Arjupta commented Apr 6, 2021

@Arjupta any update on this?

Pardon, I will replace these tests soon.

@Arjupta Arjupta marked this pull request as draft April 10, 2021 11:23
@Arjupta Arjupta marked this pull request as ready for review April 16, 2021 17:44
@Arjupta Arjupta assigned rt4914 and anandwana001 and unassigned Arjupta Apr 19, 2021
anandwana001
anandwana001 suggested changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arjupta
left few changes

app/src/main/java/org/oppia/android/app/options/ReadingTextSizeSelectionViewModel.kt Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/options/ReadingTextSizeFragmentTest.kt Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/options/ReadingTextSizeFragmentTest.kt Outdated Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/options/ReadingTextSizeFragmentTest.kt Outdated Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/options/ReadingTextSizeFragmentTest.kt Outdated Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/options/ReadingTextSizeFragmentTest.kt Outdated Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/options/ReadingTextSizeFragmentTest.kt Outdated Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/options/ReadingTextSizeFragmentTest.kt Outdated Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/options/ReadingTextSizeFragmentTest.kt Outdated Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/options/ReadingTextSizeFragmentTest.kt Outdated Show resolved Hide resolved
@anandwana001 anandwana001 assigned Arjupta and unassigned anandwana001 Apr 19, 2021
@anandwana001
Copy link
Contributor

@anandwana001 suppose in a PR the textsize scales get changed (which was not rerquired). The normal behaviour of tests should be that they must fail for this change. Now instead of failing, the tests will pass as the same scales are being used by it. This can left our tests to be redundant.

Also, suppose in the case mentioned above we really wanted to change the textsize scales, then the normal behaviour of a developer would be to change the tests too. So this way we ensure that the things that are changed unwantedly get caught by the tests. WDYT?

Looking for @rt4914 thoughts on this.

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 31, 2021
@rt4914
Copy link
Contributor

rt4914 commented May 31, 2021

@Arjupta and @anandwana001 Sent an email to both of you.

rt4914
rt4914 reviewed Jun 2, 2021
View reviewed changes
app/src/sharedTest/java/org/oppia/android/app/options/ReadingTextSizeFragmentTest.kt
private const val SMALL_TEXT_SIZE = 0
private const val MEDIUM_TEXT_SIZE = 5
private const val LARGE_TEXT_SIZE = 10
private const val SMALL_TEXT_SIZE_SCALE = 0.8f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add following comments:

  1. These duplicates are intentional to make sure that that the production values are not changed by mistake.
  2. TODO Intoduce screenshot-testing framework #1815: Remove these duplicate values once Screenshot tests are implemented.

@Arjupta PTAL

Copy link
Contributor Author

@Arjupta Arjupta Jun 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 LGTM. Adding them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO format is correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format can be confirmed from code. I just mentioned it as points.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arjupta Format these comments correctly.

// These duplicates are intentional to make sure that that the production values are not changed 
// by mistake.
// TODO(#59): 1815: Remove these duplicate values once Screenshot tests are implemented.

The above comment was for understanding not in comments format.

@Arjupta Arjupta assigned Arjupta and rt4914 and unassigned rt4914 and Arjupta Jun 2, 2021
anandwana001
anandwana001 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment regarding TODO format.

app/src/sharedTest/java/org/oppia/android/app/options/ReadingTextSizeFragmentTest.kt
private const val SMALL_TEXT_SIZE = 0
private const val MEDIUM_TEXT_SIZE = 5
private const val LARGE_TEXT_SIZE = 10
private const val SMALL_TEXT_SIZE_SCALE = 0.8f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO format is correct?

@oppiabot
Copy link

oppiabot bot commented Jun 3, 2021

Assigning @BenHenning for code owner reviews. Thanks!

rt4914
rt4914 suggested changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arjupta Blocked on the comment formatting in tests and bazel check failure.

@rt4914 rt4914 assigned Arjupta and unassigned rt4914 and BenHenning Jun 4, 2021
@Arjupta Arjupta assigned rt4914 and unassigned Arjupta Jun 7, 2021
@rt4914
Copy link
Contributor

rt4914 commented Jun 8, 2021

@Arjupta tests are still failing.

@rt4914 rt4914 assigned Arjupta and unassigned rt4914 Jun 8, 2021
@Arjupta
Copy link
Contributor Author

Arjupta commented Jun 8, 2021

@Arjupta tests are still failing.

@rt4914 the bazel tests are failing due to some other issue and not because of the code changes I guess.

@Arjupta Arjupta assigned rt4914 and unassigned Arjupta Jun 8, 2021
rt4914
rt4914 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 82d8ee4 into oppia:develop Jun 9, 2021
@Arjupta Arjupta deleted the reading-text-size branch June 13, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@fsharpasharp fsharpasharp fsharpasharp approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

@BenHenning BenHenning Awaiting requested review from BenHenning

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11y] Reading Text Size
6 participants
@Arjupta @rt4914 @anandwana001 @mschanteltc @fsharpasharp @BenHenning